Changeset 8839 in josm for trunk

Timestamp:

2015-10-09T01:06:30+02:00 (9 years ago)

Author:

Don-vip

Message:

sonar - squid:S2325 - "private" methods that don't access instance data should be "static"

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/mapmode/ExtrudeAction.java (modified) (1 diff)
• data/osm/visitor/paint/StyledMapRenderer.java (modified) (1 diff)
• io/GeoJSONWriter.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/mapmode/ExtrudeAction.java

@@ -1110 +1110 @@
      * Returns true if from1-to1 and from2-to2 vertors directions are opposite
      */
-    private boolean isOppositeDirection(EastNorth from1, EastNorth to1, EastNorth from2, EastNorth to2) {
+    private static boolean isOppositeDirection(EastNorth from1, EastNorth to1, EastNorth from2, EastNorth to2) {
         return (from1.getX()-to1.getX())*(from2.getX()-to2.getX())
               +(from1.getY()-to1.getY())*(from2.getY()-to2.getY()) < 0;

trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/StyledMapRenderer.java

@@ -1459 +1459 @@
     }
 
-    private Path2D.Double getPath(Way w) {
+    private static Path2D.Double getPath(Way w) {
         Path2D.Double path = new Path2D.Double();
         boolean initial = true;

trunk/src/org/openstreetmap/josm/io/GeoJSONWriter.java

@@ -118 +118 @@
     }
 
-    private JsonArrayBuilder getCoorArray(JsonArrayBuilder builder, EastNorth c) {
+    private static JsonArrayBuilder getCoorArray(JsonArrayBuilder builder, EastNorth c) {
         return builder.add(c.getX()).add(c.getY());
     }