Changeset 8815 in josm for trunk/src

Timestamp:

2015-10-01T21:45:34+02:00 (9 years ago)

Author:

wiktorn

Message:

Improve tile display when imagery server returns errors randomly.

• maintain current tile when calling "Load Tile" and company
• if tile has failed loading, try to display stale content from cache together with error message

File:

• trunk/src/org/openstreetmap/josm/data/imagery/TMSCachedTileLoaderJob.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/data/imagery/TMSCachedTileLoaderJob.java

@@ -166 +166 @@
 
         try {
-            if (!tile.isLoaded()) { //if someone else already loaded tile, skip all the handling
                 tile.finishLoading(); // whatever happened set that loading has finished
                 // set tile metadata
@@ -178 +177 @@
                 case SUCCESS:
                     handleNoTileAtZoom();
-                    if (object != null) {
-                        byte[] content = object.getContent();
-                        if (content != null && content.length > 0) {
-                            tile.loadImage(new ByteArrayInputStream(content));
-                            if (tile.getImage() == null) {
-                                tile.setError(tr("Could not load image from tile server"));
-                                status = false;
-                            }
-                        }
-                    }
                     int httpStatusCode = attributes.getResponseCode();
                     if (!isNoTileAtZoom() && httpStatusCode >= 400) {
@@ -197 +186 @@
                         status = false;
                     }
+                    status &= tryLoadTileImage(object); //try to keep returned image as background
                     break;
                 case FAILURE:
                     tile.setError("Problem loading tile");
-                    // no break intentional here
+                    tryLoadTileImage(object);
                     break;
                 case CANCELED:
@@ -206 +196 @@
                     // do nothing
                 }
-            }
 
             // always check, if there is some listener interested in fact, that tile has finished loading
@@ -327 +316 @@
     }
 
-
+    private boolean tryLoadTileImage(CacheEntry object) throws IOException {
+        if (object != null) {
+            byte[] content = object.getContent();
+            if (content != null && content.length > 0) {
+                tile.loadImage(new ByteArrayInputStream(content));
+                if (tile.getImage() == null) {
+                    tile.setError(tr("Could not load image from tile server"));
+                    return false;
+                }
+            }
+        }
+        return true;
+    }
 }