Changeset 8612 in josm for trunk/src/org

Timestamp:

2015-07-23T02:16:21+02:00 (9 years ago)

Author:

Don-vip

Message:

fix QA issues (javadoc, findbugs, checkstyle)

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• MapView.java (modified) (2 diffs)
• NavigatableComponent.java (modified) (2 diffs)
• dialogs/InspectPrimitiveDialog.java (modified) (1 diff)
• layer/AbstractTileSourceLayer.java (modified) (1 diff)
• mappaint/mapcss/Condition.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/MapView.java

@@ -299 +299 @@
         initialViewport = viewportData;
         Main.pref.addPreferenceChangeListener(this);
-        final boolean unregisterTab = Shortcut.findShortcut(KeyEvent.VK_TAB, 0) != null;
 
         addComponentListener(new ComponentAdapter() {
@@ -361 +360 @@
     private Point oldLoc = null;
 
-    /*
+    /**
      * Call this method to keep map position on screen during next repaint
      */

trunk/src/org/openstreetmap/josm/gui/NavigatableComponent.java

@@ -163 +163 @@
      * @return The current system of measurement (metric system by default).
      * @since 3490
-     * @deprecated use {@link SystemOfMeasurement#getSoMChangeListener} instead.
+     * @deprecated use {@link SystemOfMeasurement#getSystemOfMeasurement} instead.
      */
     @Deprecated
@@ -175 +175 @@
      * @throws IllegalArgumentException if {@code somKey} is not known
      * @since 6056
-     * @deprecated use {@link SystemOfMeasurement#setSoMChangeListener} instead.
+     * @deprecated use {@link SystemOfMeasurement#setSystemOfMeasurement} instead.
      */
     @Deprecated

trunk/src/org/openstreetmap/josm/gui/dialogs/InspectPrimitiveDialog.java

@@ -417 +417 @@
             final String username = entry.getKey();
             final Integer editCount = entry.getValue();
-            s.append(String.format("%6d  %s\n", editCount, username));
+            s.append(String.format("%6d  %s%n", editCount, username));
         }
         return s.toString();

trunk/src/org/openstreetmap/josm/gui/layer/AbstractTileSourceLayer.java

@@ -184 +184 @@
         } catch (MalformedURLException e) {
             // ignore, assume that this is not a file
+            if (Main.isDebugEnabled()) {
+                Main.debug(e.getMessage());
+            }
         }
 

trunk/src/org/openstreetmap/josm/gui/mappaint/mapcss/Condition.java

@@ -13 +13 @@
 
 import org.openstreetmap.josm.Main;
-import org.openstreetmap.josm.actions.search.SearchCompiler;
+import org.openstreetmap.josm.actions.search.SearchCompiler.InDataSourceArea;
 import org.openstreetmap.josm.data.osm.Node;
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
@@ -469 +469 @@
         }
 
-        private static final Predicate<OsmPrimitive> IN_DOWNLOADED_AREA = new SearchCompiler.InDataSourceArea(false);
+        private static final Predicate<OsmPrimitive> IN_DOWNLOADED_AREA = new InDataSourceArea(false);
 
         /**
          * {@code in-downloaded-area} tests whether the object is within source area ("downloaded area").
-         * @see SearchCompiler.InDataSourceArea
+         * @see InDataSourceArea
          */
         static boolean inDownloadedArea(Environment e) {
             return IN_DOWNLOADED_AREA.evaluate(e.osm);
         }
-
     }