Changeset 8412 in josm

Timestamp:

2015-05-22T01:06:28+02:00 (10 years ago)

Author:

Don-vip

Message:

ExecutorService field doesn't ever get shutdown

Location:

trunk/src/org/openstreetmap/josm

Files:

• Main.java (modified) (3 diffs)
• gui/io/SaveLayersDialog.java (modified) (3 diffs)
• tools/ImageProvider.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/Main.java

@@ -1081 +1081 @@
 
     /**
-     * Closes JOSM and optionally terminates the Java Virtual Machine (JVM). If there are some unsaved data layers, asks first for user confirmation.
+     * Closes JOSM and optionally terminates the Java Virtual Machine (JVM).
+     * If there are some unsaved data layers, asks first for user confirmation.
      * @param exit If {@code true}, the JVM is terminated by running {@link System#exit} with a given return code.
      * @param exitCode The return code
@@ -1088 +1089 @@
      */
     public static boolean exitJosm(boolean exit, int exitCode) {
-        JCSCacheManager.shutdown();
         if (Main.saveUnsavedModifications()) {
+            worker.shutdown();
+            ImageProvider.shutdown(false);
+            JCSCacheManager.shutdown();
             geometry.remember("gui.geometry");
             if (map != null) {
@@ -1102 +1105 @@
                 }
             }
+            worker.shutdownNow();
+            ImageProvider.shutdown(true);
+
             if (exit) {
                 System.exit(exitCode);

trunk/src/org/openstreetmap/josm/gui/io/SaveLayersDialog.java

@@ -434 +434 @@
     protected class SaveAndUploadTask implements Runnable {
 
-        private SaveLayersModel model;
-        private ProgressMonitor monitor;
-        private ExecutorService worker;
+        private final SaveLayersModel model;
+        private final ProgressMonitor monitor;
+        private final ExecutorService worker;
         private boolean canceled;
         private Future<?> currentFuture;
@@ -592 +592 @@
                 }
             });
+            worker.shutdownNow();
         }
 
@@ -598 +599 @@
                 currentTask.cancel();
             }
+            worker.shutdown();
             canceled = true;
         }

trunk/src/org/openstreetmap/josm/tools/ImageProvider.java

@@ -1612 +1612 @@
      * @return The same image as {@code bi} where all pixels of the given color are transparent.
      * This resulting image has also the special property {@link #PROP_TRANSPARENCY_FORCED} set to {@code color}
-     * @since 7132
      * @see BufferedImage#getProperty
      * @see #isTransparencyForced
+     * @since 7132
      */
     public static BufferedImage makeImageTransparent(BufferedImage bi, Color color) {
@@ -1653 +1653 @@
      * @param bi The {@code BufferedImage} to test
      * @return {@code true} if the transparency of {@code bi} has been enforced by a previous call to {@code makeImageTransparent}.
+     * @see #makeImageTransparent
      * @since 7132
-     * @see #makeImageTransparent
      */
     public static boolean isTransparencyForced(BufferedImage bi) {
@@ -1664 +1664 @@
      * @param bi The {@code BufferedImage} to test
      * @return {@code true} if {@code bi} has a transparent color determined by a previous call to {@code read}.
+     * @see #read
      * @since 7132
-     * @see #read
      */
     public static boolean hasTransparentColor(BufferedImage bi) {
         return bi != null && !bi.getProperty(PROP_TRANSPARENCY_COLOR).equals(Image.UndefinedProperty);
     }
+
+    /**
+     * Shutdown background image fetcher.
+     * @param now if {@code true}, attempts to stop all actively executing tasks, halts the processing of waiting tasks.
+     * if {@code false}, initiates an orderly shutdown in which previously submitted tasks are executed, but no new tasks will be accepted
+     * @since 8412
+     */
+    public static void shutdown(boolean now) {
+        if (now) {
+            IMAGE_FETCHER.shutdownNow();
+        } else {
+            IMAGE_FETCHER.shutdown();
+        }
+    }
 }