Changeset 8224 in josm

Timestamp:

2015-04-18T22:37:12+02:00 (10 years ago)

Author:

simon04

Message:

see #10980 - Note download: update already downloaded non-modified notes; use Storage for internal storage

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/osm/NoteData.java (modified) (8 diffs)
• gui/dialogs/NotesDialog.java (modified) (9 diffs)
• gui/layer/NoteLayer.java (modified) (4 diffs)
• io/NoteReader.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/osm/NoteData.java

@@ -3 +3 @@
 
 import java.util.ArrayList;
+import java.util.Collection;
 import java.util.Collections;
 import java.util.Comparator;
 import java.util.Date;
-import java.util.List;
 import java.util.Map;
 
@@ -15 +15 @@
 import org.openstreetmap.josm.data.notes.NoteComment;
 import org.openstreetmap.josm.gui.JosmUserIdentityManager;
+import org.openstreetmap.josm.tools.Predicate;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -23 +25 @@
     private long newNoteId = -1;
 
-    private final List<Note> noteList;
+    private final Storage<Note> noteList;
     private Note selectedNote = null;
     private Comparator<Note> comparator = DEFAULT_COMPARATOR;
@@ -85 +87 @@
 
     /**
-     * Construct a new note container with an empty note list
-     */
-    public NoteData() {
-        noteList = new ArrayList<>();
-    }
-
-    /**
      * Construct a new note container with a given list of notes
      * @param notes The list of notes to populate the container with
      */
-    public NoteData(List<Note> notes) {
-        noteList = notes;
-        Collections.sort(notes, comparator);
+    public NoteData(Collection<Note> notes) {
+        noteList = new Storage<>();
         for (Note note : notes) {
+            noteList.add(note);
             if (note.getId() <= newNoteId) {
                 newNoteId = note.getId() - 1;
@@ -107 +102 @@
     /**
      * Returns the notes stored in this layer
-     * @return List of Note objects
-     */
-    public List<Note> getNotes() {
-        return noteList;
+     * @return collection of notes
+     */
+    public Collection<Note> getNotes() {
+        return Collections.unmodifiableCollection(noteList);
+    }
+
+    /**
+     * Returns the notes stored in this layer sorted according to {@link #comparator}
+     * @return sorted collection of notes
+     */
+    public Collection<Note> getSortedNotes() {
+        final ArrayList<Note> list = new ArrayList<>(noteList);
+        Collections.sort(list, comparator);
+        return list;
     }
 
@@ -155 +160 @@
      * @param newNotes A list of notes to add
      */
-    public synchronized void addNotes(List<Note> newNotes) {
+    public synchronized void addNotes(Collection<Note> newNotes) {
         for (Note newNote : newNotes) {
             if (!noteList.contains(newNote)) {
                 noteList.add(newNote);
+            } else {
+                final Note existingNote = noteList.get(newNote);
+                final boolean isDirty = Utils.exists(existingNote.getComments(), new Predicate<NoteComment>() {
+                    @Override
+                    public boolean evaluate(NoteComment object) {
+                        return object.getIsNew();
+                    }
+                });
+                if (!isDirty) {
+                    noteList.put(newNote);
+                } else {
+                    // TODO merge comments?
+                    Main.info("Keeping existing note id={0} with uncommitted changes", String.valueOf(newNote.getId()));
+                }
             }
             if (newNote.getId() <= newNoteId) {
@@ -165 +184 @@
         }
         dataUpdated();
-        if (Main.isDebugEnabled()) {
-            Main.debug("notes in current set: " + noteList.size());
-        }
     }
 
@@ -256 +272 @@
 
     private void dataUpdated() {
-        Collections.sort(noteList, comparator);
-        Main.map.noteDialog.setNoteList(noteList);
+        Main.map.noteDialog.setNotes(getSortedNotes());
         Main.map.mapView.repaint();
     }

trunk/src/org/openstreetmap/josm/gui/dialogs/NotesDialog.java

@@ -13 +13 @@
 import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.Collection;
 import java.util.List;
 
@@ -186 +187 @@
             noteData = ((NoteLayer)newLayer).getNoteData();
             model.setData(noteData.getNotes());
-            setNoteList(noteData.getNotes());
+            setNotes(noteData.getSortedNotes());
         }
     }
@@ -193 +194 @@
     public void layerRemoved(Layer oldLayer) {
         if (oldLayer instanceof NoteLayer) {
-            if (Main.isDebugEnabled()) {
-                Main.debug("note layer removed. Clearing everything");
-            }
             noteData = null;
             model.clearData();
@@ -209 +207 @@
      * @param noteList List of notes to display
      */
-    public void setNoteList(List<Note> noteList) {
+    public void setNotes(Collection<Note> noteList) {
         model.setData(noteList);
         updateButtonStates();
@@ -265 +263 @@
 
         public NoteTableModel() {
-            data = new ArrayList<Note>();
+            data = new ArrayList<>();
         }
 
@@ -281 +279 @@
         }
 
-        public void setData(List<Note> noteList) {
+        public void setData(Collection<Note> noteList) {
             data.clear();
             data.addAll(noteList);
@@ -315 +313 @@
             dialog.showNoteDialog(tr("Add comment to note:"), NotesDialog.ICON_COMMENT);
             if (dialog.getValue() != 1) {
-                Main.debug("User aborted note reopening");
                 return;
             }
@@ -337 +334 @@
             dialog.showNoteDialog(tr("Close note with message:"), NotesDialog.ICON_CLOSED);
             if (dialog.getValue() != 1) {
-                Main.debug("User aborted note closing");
                 return;
             }
@@ -377 +373 @@
             dialog.showNoteDialog(tr("Reopen note with message:"), NotesDialog.ICON_OPEN);
             if (dialog.getValue() != 1) {
-                Main.debug("User aborted note reopening");
                 return;
             }

trunk/src/org/openstreetmap/josm/gui/layer/NoteLayer.java

@@ -13 +13 @@
 import java.text.DateFormat;
 import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
 import java.util.List;
 
@@ -56 +58 @@
      * @param name The name of the layer. Typically "Notes"
      */
-    public NoteLayer(List<Note> notes, String name) {
+    public NoteLayer(Collection<Note> notes, String name) {
         super(name);
         noteData = new NoteData(notes);
@@ -63 +65 @@
     /** Convenience constructor that creates a layer with an empty note list */
     public NoteLayer() {
-        super(tr("Notes"));
-        noteData = new NoteData();
+        this(Collections.<Note>emptySet(), tr("Notes"));
     }
 
@@ -97 +98 @@
     @Override
     public boolean requiresSaveToFile() {
-        Main.debug("associated notes file: " + getAssociatedFile());
         return getAssociatedFile() != null && isModified();
     }

trunk/src/org/openstreetmap/josm/io/NoteReader.java

@@ -195 +195 @@
         @Override
         public void endDocument() throws SAXException  {
-            Main.info("parsed notes: " + notes.size());
             parsedNotes = notes;
         }
@@ -210 +209 @@
                 return sdf.parse(dateStr);
             } catch(ParseException e) {
-                Main.error("error parsing date in note parser");
+                Main.error(e);
                 return null;
             }