Changeset 8135 in josm for trunk/data

Timestamp:

2015-03-13T20:34:02+01:00 (10 years ago)

Author:

Klumbumbus

Message:

fix #11223 - remove waterway=wadi and waterway=rapids, update natural=ridge, natural=valley and intermittent=yes

Location:

trunk/data

Files:

• defaultpresets.xml (modified) (7 diffs)
• validator/deprecated.mapcss (modified) (1 diff)
• validator/geometry.mapcss (modified) (2 diffs)

trunk/data/defaultpresets.xml

@@ -1674 +1674 @@
             <text key="name" text="Name" />
             <combo key="layer" text="Layer" values="5,4,3,2,1,0,-1,-2,-3,-4,-5" length="3" />
+            <check key="intermittent" text="Is the water body intermittent (disappears seasonally)?" disable_off="true" />
         </item> <!-- Drain -->
         <item name="Ditch" icon="presets/waterway.png" type="way" preset_name_label="true">
@@ -1685 +1686 @@
             <text key="name" text="Name" />
             <combo key="layer" text="Layer" values="5,4,3,2,1,0,-1,-2,-3,-4,-5" length="3" />
+            <check key="intermittent" text="Is the water body intermittent (disappears seasonally)?" disable_off="true" />
         </item> <!-- Ditch -->
         <item name="Stream" icon="presets/waterway.png" type="way" preset_name_label="true">
@@ -1701 +1703 @@
             <text key="name" text="Name" />
             <combo key="layer" text="Layer" values="5,4,3,2,1,0,-1,-2,-3,-4,-5" length="3" />
+            <check key="intermittent" text="Is the water body intermittent (disappears seasonally)?" disable_off="true" />
         </item> <!-- Stream -->
-        <item name="Wadi" icon="presets/waterway.png" type="way" preset_name_label="true">
-            <link href="http://wiki.openstreetmap.org/wiki/Tag:waterway=wadi" />
-            <space />
-            <key key="waterway" value="wadi" />
-            <text key="name" text="Name" />
-            <combo key="layer" text="Layer" values="5,4,3,2,1,0,-1,-2,-3,-4,-5" length="3" />
-        </item> <!-- Wadi -->
         <item name="Canal" icon="presets/waterway.png" type="way" preset_name_label="true">
             <link href="http://wiki.openstreetmap.org/wiki/Tag:waterway=canal"
@@ -1736 +1732 @@
             <reference ref="name_wikipedia" />
             <combo key="layer" text="Layer" values="5,4,3,2,1,0,-1,-2,-3,-4,-5" length="3" />
+            <check key="intermittent" text="Is the water body intermittent (disappears seasonally)?" disable_off="true" />
         </item> <!-- River -->
         <separator/>
@@ -1894 +1891 @@
             <key key="waterway" value="riverbank" />
             <text key="name" text="Name" />
+            <check key="intermittent" text="Is the water body intermittent (disappears seasonally)?" disable_off="true" />
         </item> <!-- Riverbank -->
         <separator/>
@@ -7204 +7202 @@
             </optional>
         </item> <!-- Volcano -->
+        <item name="Ridge" icon="presets/ridge.svg" type="way,relation" preset_name_label="true">
+            <link href="http://wiki.openstreetmap.org/wiki/Tag:natural=ridge"
+                  cs.href="http://wiki.openstreetmap.org/wiki/Cs:Tag:natural=ridge"
+                  de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:natural=ridge"
+                  pl.href="http://wiki.openstreetmap.org/wiki/Pl:Tag:natural=ridge"
+                  ru.href="http://wiki.openstreetmap.org/wiki/RU:Tag:natural=ridge" />
+            <label text="A mountain or hill ridge." />
+            <space />
+            <key key="natural" value="ridge" />
+            <reference ref="name_wikipedia" />
+            <text key="ele" text="Elevation" />
+        </item> <!-- Ridge -->
+        <item name="Valley" icon="presets/valley.svg" type="way,relation" preset_name_label="true">
+            <link href="http://wiki.openstreetmap.org/wiki/Tag:natural=valley" />
+            <label text="A low area between hills." />
+            <space />
+            <key key="natural" value="valley" />
+            <reference ref="name_wikipedia" />
+        </item> <!-- Valley -->
         <item name="Cave Entrance" icon="presets/cave_entrance.png" type="node,closedway,relation" preset_name_label="true">
             <link href="http://wiki.openstreetmap.org/wiki/Tag:natural=cave_entrance"
@@ -7240 +7257 @@
             <reference ref="name_wikipedia" />
         </item> <!-- Islet -->
-        <item name="Ridge" icon="presets/empty.png" type="way,relation" preset_name_label="true">
-            <link href="http://wiki.openstreetmap.org/wiki/Tag:natural=ridge"
-                  cs.href="http://wiki.openstreetmap.org/wiki/Cs:Tag:natural=ridge"
-                  de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:natural=ridge"
-                  pl.href="http://wiki.openstreetmap.org/wiki/Pl:Tag:natural=ridge"
-                  ru.href="http://wiki.openstreetmap.org/wiki/RU:Tag:natural=ridge" />
-            <label text="A mountain or hill ridge." />
-            <space />
-            <key key="natural" value="ridge" />
-            <reference ref="name_wikipedia" />
-            <text key="ele" text="Elevation" />
-        </item> <!-- Ridge -->
     </group> <!-- Geography -->
     <group name="Nature" icon="styles/standard/misc/landmark/trees.png">

trunk/data/validator/deprecated.mapcss

@@ -398 +398 @@
   suggestAlternative: {1.key};
 }
+
+/* see #11223 */
+*[waterway=wadi] {
+  throwWarning: tr("{0} is deprecated", "{0.tag}");
+  suggestAlternative: "{0.key}=* + intermittent=yes";
+  suggestAlternative: "natural=valley";
+}

trunk/data/validator/geometry.mapcss

@@ -30 +30 @@
 node[waterway=river],
 node[waterway=canal],
-node[waterway=wadi],
 node[waterway=stream],
 node[waterway=ditch],
@@ -36 +35 @@
 node[natural=coastline],
 node[natural=ridge],
+node[natural=valley],
 node[natural=tree_row] {
   throwWarning: tr("{0} on a node. Should be used on a way.", "{0.tag}");