Changeset 8000 in josm for trunk/src/org/openstreetmap/josm/gui/widgets

Timestamp:

2015-02-02T21:46:25+01:00 (10 years ago)

Author:

Don-vip

Message:

fix #11046 - bind Undo action to Ctrl-Z in JosmTextField

Location:

trunk/src/org/openstreetmap/josm/gui/widgets

Files:

• JosmTextField.java (modified) (1 diff)
• TextContextualPopupMenu.java (modified) (8 diffs)

trunk/src/org/openstreetmap/josm/gui/widgets/JosmTextField.java

@@ -18 +18 @@
 /**
  * Subclass of {@link JTextField} that:<ul>
- * <li>adds a "native" context menu (cut/copy/paste/select all)</li>
+ * <li>adds a "native" context menu (undo/cut/copy/paste/select all)</li>
  * <li>adds an optional "hint" displayed when no text has been entered</li>
  * <li>disables the global advanced key press detector when focused</li>

trunk/src/org/openstreetmap/josm/gui/widgets/TextContextualPopupMenu.java

@@ -4 +4 @@
 import static org.openstreetmap.josm.tools.I18n.tr;
 
+import java.awt.Toolkit;
 import java.awt.event.ActionEvent;
+import java.awt.event.KeyEvent;
 import java.beans.PropertyChangeEvent;
 import java.beans.PropertyChangeListener;
@@ -13 +15 @@
 import javax.swing.JMenuItem;
 import javax.swing.JPopupMenu;
+import javax.swing.KeyStroke;
 import javax.swing.event.UndoableEditEvent;
 import javax.swing.event.UndoableEditListener;
@@ -37 +40 @@
 public class TextContextualPopupMenu extends JPopupMenu {
 
+    private static final String EDITABLE = "editable";
+
     protected JTextComponent component = null;
     protected UndoAction undoAction = null;
@@ -42 +47 @@
     protected final PropertyChangeListener propertyChangeListener = new PropertyChangeListener() {
         @Override public void propertyChange(PropertyChangeEvent evt) {
-            if ("editable".equals(evt.getPropertyName())) {
+            if (EDITABLE.equals(evt.getPropertyName())) {
                 removeAll();
                 addMenuEntries();
@@ -68 +73 @@
                 undoAction = new UndoAction();
                 component.getDocument().addUndoableEditListener(undoAction);
+                component.getInputMap().put(
+                        KeyStroke.getKeyStroke(KeyEvent.VK_Z, Toolkit.getDefaultToolkit().getMenuShortcutKeyMask()), undoAction);
             }
             addMenuEntries();
-            component.addPropertyChangeListener("editable", propertyChangeListener);
+            component.addPropertyChangeListener(EDITABLE, propertyChangeListener);
         }
         return this;
@@ -97 +104 @@
     protected TextContextualPopupMenu detach() {
         if (isAttached()) {
-            component.removePropertyChangeListener("editable", propertyChangeListener);
+            component.removePropertyChangeListener(EDITABLE, propertyChangeListener);
             removeAll();
             if (undoAction != null) {
@@ -161 +168 @@
         private final UndoManager undoManager = new UndoManager();
 
+        /**
+         * Constructs a new {@code UndoAction}.
+         */
         public UndoAction() {
             super(tr("Undo"));
@@ -177 +187 @@
                 undoManager.undo();
             } catch (CannotUndoException ex) {
-                // Ignored
+                if (Main.isTraceEnabled()) {
+                    Main.trace(ex.getMessage());
+                }
             } finally {
                 setEnabled(undoManager.canUndo());