Changeset 7967 in josm

Timestamp:

2015-01-15T00:47:55+01:00 (10 years ago)

Author:

Klumbumbus

Message:

see #10835 - icon unification and geometry consistency for some power tags. add validator warnings

Location:

trunk

Files:

• data/defaultpresets.xml (modified) (5 diffs)
• data/validator/combinations.mapcss (modified) (1 diff)
• data/validator/geometry.mapcss (modified) (2 diffs)
• images_nodist/icons/power_tower_high2.n.16.png (moved) (moved from trunk/images/icons/power_tower_high2.n.16.png )
• images_nodist/icons/power_tower_low.n.16.png (moved) (moved from trunk/images/icons/power_tower_low.n.16.png )
• styles/standard/elemstyles.mapcss (modified) (4 diffs)

trunk/data/defaultpresets.xml

@@ -5533 +5533 @@
         </item> <!-- Power Transformer -->
         <item name="Power Switchgear" icon="presets/power.png" type="closedway" preset_name_label="true">
-            <link href="http://wiki.openstreetmap.org/wiki/Tag:power=switch"
+            <link href="http://wiki.openstreetmap.org/wiki/Tag:power=switchgear"
                   de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:power=substation"
                   it.href="http://wiki.openstreetmap.org/wiki/IT:Tag:power=substation"
@@ -5609 +5609 @@
         <separator/>
         <item name="Cable Distribution Cabinet" icon="presets/power.png" type="node" preset_name_label="true">
-            <link href="http://wiki.openstreetmap.org/wiki/Tag:power=cable"
+            <link href="http://wiki.openstreetmap.org/wiki/Tag:power=cable_distribution_cabinet"
                   de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:power=cable"
                   it.href="http://wiki.openstreetmap.org/wiki/IT:Tag:power=cable" />
@@ -5618 +5618 @@
         </item> <!-- Cable Distribution Cabinet -->
         <separator/>
-        <item name="Power Tower" icon="icons/power_tower_high2.n.16.png" type="node" preset_name_label="true">
+        <item name="Power Tower" icon="styles/standard/misc/landmark/power/tower_small.png" type="node" preset_name_label="true">
             <link href="http://wiki.openstreetmap.org/wiki/Tag:power=tower"
                   de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:power=tower"
@@ -5643 +5643 @@
             </optional>
         </item> <!-- Power Tower -->
-        <item name="Pole" icon="icons/power_tower_low.n.16.png" type="node" preset_name_label="true">
+        <item name="Pole" icon="styles/standard/misc/landmark/power/pole.png" type="node" preset_name_label="true">
             <link href="http://wiki.openstreetmap.org/wiki/Tag:power=pole"
                   de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:power=pole"
@@ -5658 +5658 @@
             <reference ref="ref_operator_branch" />
         </item> <!-- Pole -->
-        <item name="Pole with Transformer" icon="icons/power_tower_low.n.16.png" type="node" preset_name_label="true">
+        <item name="Pole with Transformer" icon="styles/standard/misc/landmark/power/pole.png" type="node" preset_name_label="true">
             <link href="http://wiki.openstreetmap.org/wiki/Tag:power=pole"
                   de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:power=pole"

trunk/data/validator/combinations.mapcss

@@ -108 +108 @@
 /* {0.tag} without {1.key} */
 *[aeroway=terminal][!building],
+*[power=generator][!generator:source],
 *[amenity=place_of_worship][!religion] {
   throwWarning: tr("{0} without {1}", "{0.tag}", "{1.key}");

trunk/data/validator/geometry.mapcss

@@ -49 +49 @@
 node[waterway=riverbank],
 node[man_made=bridge],
+node[power=plant],
 node[source:outline] {
   throwWarning: tr("{0} on a node. Should be drawn as an area.", "{0.tag}");
@@ -62 +63 @@
 way[entrance],
 way[man_made=survey_point],
+way[power=pole],
 way[natural=peak],
 way[natural=saddle],

trunk/styles/standard/elemstyles.mapcss

@@ -1072 +1072 @@
 /**************/
 
-area[power=tower] {
-    fill-color: power#eeeeee;
-}
 node[power=tower] {
     icon-image: "misc/landmark/power/tower_small.png";
@@ -1095 +1092 @@
     dashes: 9,9;
 }
+node[power=plant],
+node[power=sub_station],
 node[power=line],
 node[power=cable],
@@ -1103 +1102 @@
 }
 area[power=plant],
-area[power=sub_station],
 area[power=substation],
 area[power=transformer],
+area[power=compensator],
+area[power=converter],
 area[power=generator] {
     fill-color: power#eeeeee;
 }
-node[power=plant],
-node[power=sub_station],
-node[power=substation],
 node[power=cable_distribution_cabinet],
 node[power=generator] {
@@ -1118 +1115 @@
     text: auto;
 }
+node[power=substation] {
+    icon-image: "icons/power_substation.n.16.png";
+    set icon_z17;
+    text: auto;
+}
 node[power=transformer] {
     icon-image: "misc/landmark/power/transformer.png";
+    icon-width: 16;
     set icon_z17;
     text: auto;