Changeset 7863 in josm

Timestamp:

2014-12-20T22:08:29+01:00 (10 years ago)

Author:

Don-vip

Message:

fix #10470 - fix invalid recognition of items in AutoCompletionComboBox

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• tagging/ac/AutoCompletingComboBox.java (modified) (1 diff)
• tagging/ac/AutoCompletionListItem.java (modified) (3 diffs)
• widgets/JosmComboBox.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/tagging/ac/AutoCompletingComboBox.java

@@ -247 +247 @@
             }
             super.setSelectedItem(new AutoCompletionListItem(s, AutoCompletionItemPriority.UNKNOWN));
-        } else
-            throw new IllegalArgumentException();
+        } else {
+            throw new IllegalArgumentException("Unsupported item: "+item);
+        }
     }
 

trunk/src/org/openstreetmap/josm/gui/tagging/ac/AutoCompletionListItem.java

@@ -1 +1 @@
 // License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.gui.tagging.ac;
+
+import org.openstreetmap.josm.tools.CheckParameterUtil;
 
 /**
@@ -79 +81 @@
      */
     public void setValue(String value) {
-        if (value == null)
-            throw new IllegalArgumentException("argument 'value' must not be null");
+        CheckParameterUtil.ensureParameterNotNull(value, "value");
         this.value = value;
     }
@@ -108 +109 @@
         if (obj == null)
             return false;
+        if (obj instanceof String)
+            return obj.equals(value);
         if (getClass() != obj.getClass())
             return false;

trunk/src/org/openstreetmap/josm/gui/widgets/JosmComboBox.java

@@ -160 +160 @@
             JList<E> list = getList();
             if (list != null) {
-                if (list.getPrototypeCellValue() != prototype) {
+                if (!prototype.equals(list.getPrototypeCellValue())) {
                     list.setPrototypeCellValue(prototype);
                 }
@@ -197 +197 @@
 
         private void enableMenu() {
-            if (launcher == null) {
-                if (editor != null) {
-                    Component editorComponent = editor.getEditorComponent();
-                    if (editorComponent instanceof JTextComponent) {
-                        component = (JTextComponent) editorComponent;
-                        component.addMouseListener(this);
-                        launcher = TextContextualPopupMenu.enableMenuFor(component);
-                    }
+            if (launcher == null && editor != null) {
+                Component editorComponent = editor.getEditorComponent();
+                if (editorComponent instanceof JTextComponent) {
+                    component = (JTextComponent) editorComponent;
+                    component.addMouseListener(this);
+                    launcher = TextContextualPopupMenu.enableMenuFor(component);
                 }
             }
@@ -229 +227 @@
 
         private void processEvent(MouseEvent e) {
-            if (launcher != null && !e.isPopupTrigger()) {
-                if (launcher.getMenu().isShowing()) {
-                    launcher.getMenu().setVisible(false);
-                }
+            if (launcher != null && !e.isPopupTrigger() && launcher.getMenu().isShowing()) {
+                launcher.getMenu().setVisible(false);
             }
         }