Changeset 7075 in josm

Timestamp:

2014-05-08T02:40:40+02:00 (10 years ago)

Author:

Don-vip

Message:

Robustness to allow to run more unit tests in headless mode

Location:

trunk

Files:

• src/org/openstreetmap/josm/gui/GettingStarted.java (modified) (2 diffs)
• src/org/openstreetmap/josm/gui/ImageryMenu.java (modified) (4 diffs)
• src/org/openstreetmap/josm/gui/MainMenu.java (modified) (2 diffs)
• src/org/openstreetmap/josm/gui/MapFrame.java (modified) (4 diffs)
• src/org/openstreetmap/josm/io/auth/AbstractCredentialsAgent.java (modified) (2 diffs)
• src/org/openstreetmap/josm/tools/ImageProvider.java (modified) (4 diffs)
• src/org/openstreetmap/josm/tools/PlatformHookUnixoid.java (modified) (2 diffs)
• test/unit/org/openstreetmap/josm/io/session/SessionWriterTest.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/GettingStarted.java

@@ -7 +7 @@
 import java.awt.BorderLayout;
 import java.awt.EventQueue;
+import java.awt.GraphicsEnvironment;
 import java.awt.event.InputEvent;
 import java.awt.event.KeyEvent;
@@ -126 +127 @@
         getMOTD();
 
-        new FileDrop(scroller);
+        if (!GraphicsEnvironment.isHeadless()) {
+            new FileDrop(scroller);
+        }
     }
 

trunk/src/org/openstreetmap/josm/gui/ImageryMenu.java

@@ -6 +6 @@
 
 import java.awt.Component;
+import java.awt.GraphicsEnvironment;
 import java.awt.MenuComponent;
 import java.awt.Toolkit;
@@ -104 +105 @@
         MainMenu.add(subMenu, rectaction);
     }
-    
+
     private void setupMenuScroller() {
-        int screenHeight = Toolkit.getDefaultToolkit().getScreenSize().height;
-        int menuItemHeight = singleOffset.getPreferredSize().height;
-        MenuScroller.setScrollerFor(this, (screenHeight / menuItemHeight)-1);
+        if (!GraphicsEnvironment.isHeadless()) {
+            int screenHeight = Toolkit.getDefaultToolkit().getScreenSize().height;
+            int menuItemHeight = singleOffset.getPreferredSize().height;
+            MenuScroller.setScrollerFor(this, (screenHeight / menuItemHeight)-1);
+        }
     }
 
@@ -234 +237 @@
 
     /**
-     * Collection to store temporary menu items. They will be deleted 
+     * Collection to store temporary menu items. They will be deleted
      * (and possibly recreated) when refreshImageryMenu() is called.
      * @since 5803
      */
     private List <Object> dynamicItems = new ArrayList<>(20);
-    
+
     /**
      * Remove all the items in @field dynamicItems collection
@@ -264 +267 @@
         add(s);
     }
-    
+
     private void addDynamic(Action a) {
         dynamicItems.add( this.add(a) );
     }
-    
+
     private void addDynamic(JMenuItem it) {
         dynamicItems.add( this.add(it) );

trunk/src/org/openstreetmap/josm/gui/MainMenu.java

@@ -7 +7 @@
 
 import java.awt.Component;
+import java.awt.GraphicsEnvironment;
 import java.awt.Toolkit;
 import java.awt.event.KeyEvent;
@@ -567 +568 @@
     public JMenu addMenu(String name, int mnemonicKey, int position, String relativeHelpTopic) {
         final JMenu menu = new JMenu(tr(name));
-        int screenHeight = Toolkit.getDefaultToolkit().getScreenSize().height;
-        int menuItemHeight = new JMenu().add(newAction).getPreferredSize().height;
-        MenuScroller.setScrollerFor(menu, screenHeight / menuItemHeight);
+        if (!GraphicsEnvironment.isHeadless()) {
+            int screenHeight = Toolkit.getDefaultToolkit().getScreenSize().height;
+            int menuItemHeight = new JMenu().add(newAction).getPreferredSize().height;
+            MenuScroller.setScrollerFor(menu, screenHeight / menuItemHeight);
+        }
         return addMenu(menu, name, mnemonicKey, position, relativeHelpTopic);
     }

trunk/src/org/openstreetmap/josm/gui/MapFrame.java

@@ -9 +9 @@
 import java.awt.Dimension;
 import java.awt.Font;
+import java.awt.GraphicsEnvironment;
 import java.awt.GridBagLayout;
 import java.awt.Rectangle;
@@ -53 +54 @@
 import org.openstreetmap.josm.actions.mapmode.ZoomAction;
 import org.openstreetmap.josm.data.Preferences;
-import org.openstreetmap.josm.data.ViewportData;
 import org.openstreetmap.josm.data.Preferences.PreferenceChangeEvent;
 import org.openstreetmap.josm.data.Preferences.PreferenceChangedListener;
+import org.openstreetmap.josm.data.ViewportData;
 import org.openstreetmap.josm.gui.MapView.LayerChangeListener;
 import org.openstreetmap.josm.gui.dialogs.ChangesetDialog;
@@ -161 +162 @@
 
         mapView = new MapView(contentPane, viewportData);
-        new FileDrop(mapView);
+        if (!GraphicsEnvironment.isHeadless()) {
+            new FileDrop(mapView);
+        }
 
         splitPane = new JSplitPane(JSplitPane.HORIZONTAL_SPLIT, true);
@@ -599 +602 @@
 
     /**
-     * Remove panel from top of MapView by class     
+     * Remove panel from top of MapView by class
      */
     public void removeTopPanel(Class<?> type) {

trunk/src/org/openstreetmap/josm/io/auth/AbstractCredentialsAgent.java

@@ -2 +2 @@
 package org.openstreetmap.josm.io.auth;
 
+import java.awt.GraphicsEnvironment;
 import java.net.Authenticator.RequestorType;
 import java.net.PasswordAuthentication;
@@ -44 +45 @@
          */
         } else if (noSuccessWithLastResponse || username.isEmpty() || password.isEmpty()) {
-            GuiHelper.runInEDTAndWait(new Runnable() {
-                @Override
-                public void run() {
-                    CredentialDialog dialog = null;
-                    if (requestorType.equals(RequestorType.PROXY))
-                        dialog = CredentialDialog.getHttpProxyCredentialDialog(username, password, host, getSaveUsernameAndPasswordCheckboxText());
-                    else
-                        dialog = CredentialDialog.getOsmApiCredentialDialog(username, password, host, getSaveUsernameAndPasswordCheckboxText());
-                    dialog.setVisible(true);
-                    response.setCanceled(dialog.isCanceled());
-                    if (dialog.isCanceled())
-                        return;
-                    response.setUsername(dialog.getUsername());
-                    response.setPassword(dialog.getPassword());
-                    response.setSaveCredentials(dialog.isSaveCredentials());
-                }
-            });
+            if (!GraphicsEnvironment.isHeadless()) {
+                GuiHelper.runInEDTAndWait(new Runnable() {
+                    @Override
+                    public void run() {
+                        CredentialDialog dialog = null;
+                        if (requestorType.equals(RequestorType.PROXY))
+                            dialog = CredentialDialog.getHttpProxyCredentialDialog(
+                                    username, password, host, getSaveUsernameAndPasswordCheckboxText());
+                        else
+                            dialog = CredentialDialog.getOsmApiCredentialDialog(
+                                    username, password, host, getSaveUsernameAndPasswordCheckboxText());
+                        dialog.setVisible(true);
+                        response.setCanceled(dialog.isCanceled());
+                        if (dialog.isCanceled())
+                            return;
+                        response.setUsername(dialog.getUsername());
+                        response.setPassword(dialog.getPassword());
+                        response.setSaveCredentials(dialog.isSaveCredentials());
+                    }
+                });
+            }
             if (response.isCanceled() || response.getUsername() == null || response.getPassword() == null) {
                 return response;

trunk/src/org/openstreetmap/josm/tools/ImageProvider.java

@@ -8 +8 @@
 import java.awt.Graphics;
 import java.awt.Graphics2D;
-import java.awt.GraphicsConfiguration;
 import java.awt.GraphicsEnvironment;
 import java.awt.Image;
@@ -14 +13 @@
 import java.awt.RenderingHints;
 import java.awt.Toolkit;
-import java.awt.Transparency;
 import java.awt.image.BufferedImage;
 import java.io.ByteArrayInputStream;
@@ -793 +791 @@
             img = overlay(img, ImageProvider.get("cursor/modifier/" + overlay), OverlayPosition.SOUTHEAST);
         }
+        if (GraphicsEnvironment.isHeadless()) {
+            Main.warn("Cursors are not available in headless mode. Returning null for '"+name+"'");
+            return null;
+        }
         return Toolkit.getDefaultToolkit().createCustomCursor(img.getImage(),
                 "crosshair".equals(name) ? new Point(10, 10) : new Point(3, 2), "Cursor");
@@ -808 +810 @@
      */
     public static ImageIcon overlay(Icon ground, Icon overlay, OverlayPosition pos) {
-        GraphicsConfiguration conf = GraphicsEnvironment.getLocalGraphicsEnvironment().getDefaultScreenDevice()
-                .getDefaultConfiguration();
         int w = ground.getIconWidth();
         int h = ground.getIconHeight();
         int wo = overlay.getIconWidth();
         int ho = overlay.getIconHeight();
-        BufferedImage img = conf.createCompatibleImage(w, h, Transparency.TRANSLUCENT);
+        BufferedImage img = new BufferedImage(w, h, BufferedImage.TYPE_INT_ARGB);
         Graphics g = img.createGraphics();
         ground.paintIcon(null, g, 0, 0);

trunk/src/org/openstreetmap/josm/tools/PlatformHookUnixoid.java

@@ -99 +99 @@
     @Override
     public boolean canFullscreen() {
-        return GraphicsEnvironment.getLocalGraphicsEnvironment()
+        return !GraphicsEnvironment.isHeadless() &&
+                GraphicsEnvironment.getLocalGraphicsEnvironment()
         .getDefaultScreenDevice().isFullScreenSupported();
     }
@@ -328 +329 @@
     }
 
-    // Method kept because strings have already been translated. To enable for Java 8 migration somewhere in 2016 
+    // Method kept because strings have already been translated. To enable for Java 8 migration somewhere in 2016
     protected void askUpdateJava(final String version, final String url) {
         GuiHelper.runInEDTAndWait(new Runnable() {

trunk/test/unit/org/openstreetmap/josm/io/session/SessionWriterTest.java

@@ -4 +4 @@
 import java.io.File;
 import java.io.IOException;
-import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
@@ -19 +18 @@
 import org.openstreetmap.josm.gui.layer.Layer;
 import org.openstreetmap.josm.gui.layer.OsmDataLayer;
+import org.openstreetmap.josm.gui.preferences.ToolbarPreferences;
+import org.openstreetmap.josm.gui.preferences.projection.ProjectionPreference;
 import org.openstreetmap.josm.tools.MultiMap;
 
@@ -75 +76 @@
         Main.initApplicationPreferences();
         Main.determinePlatformHook();
-        Main.preConstructorInit(new HashMap<MainApplication.Option, Collection<String>>());
+        ProjectionPreference.setProjection();
+        Main.toolbar = new ToolbarPreferences();
         new MainApplication();
         Main.main.createMapFrame(null, null);