Changeset 6852 in josm for trunk/src

Timestamp:

2014-02-14T16:08:08+01:00 (11 years ago)

Author:

Don-vip

Message:

see #9710 - more debug messages

Location:

trunk/src/org/openstreetmap/josm

Files:

• Main.java (modified) (6 diffs)
• data/validation/OsmValidator.java (modified) (1 diff)
• gui/MapStatus.java (modified) (1 diff)
• io/OsmApi.java (modified) (2 diffs)
• io/OsmServerReader.java (modified) (1 diff)
• tools/Utils.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/Main.java

@@ -282 +282 @@
 
     /**
+     * Determines if debug log level is enabled.
+     * Useful to avoid costly construction of debug messages when not enabled.
+     * @return {@code true} if log level is at least debug, {@code false} otherwise
+     * @since 6852
+     */
+    public static boolean isDebugEnabled() {
+        return logLevel >= 4;
+    }
+
+    /**
+     * Determines if trace log level is enabled.
+     * Useful to avoid costly construction of trace messages when not enabled.
+     * @return {@code true} if log level is at least trace, {@code false} otherwise
+     * @since 6852
+     */
+    public static boolean isTraceEnabled() {
+        return logLevel >= 5;
+    }
+
+    /**
      * Prints a formatted error message if logging is on. Calls {@link MessageFormat#format}
      * function to format text.
@@ -595 +615 @@
             final long startTime = System.currentTimeMillis();
             initialize();
-            final long elapsedTime = System.currentTimeMillis() - startTime;
-            Main.debug(tr("{0} completed in {1}", name, Utils.getDurationString(elapsedTime)));
+            if (isDebugEnabled()) {
+                final long elapsedTime = System.currentTimeMillis() - startTime;
+                Main.debug(tr("{0} completed in {1}", name, Utils.getDurationString(elapsedTime)));
+            }
             return null;
         }
@@ -660 +682 @@
         return getEditLayer().data;
     }
-    
+
     /**
      * Replies the current selected primitives, from a end-user point of view.
@@ -666 +688 @@
      * Indeed, if the user is currently in drawing mode, only the way currently being drawn is returned,
      * see {@link DrawAction#getInProgressSelection()}.
-     * 
+     *
      * @return The current selected primitives, from a end-user point of view. Can be {@code null}.
      * @since 6546
@@ -1421 +1443 @@
      * Adds a new network error that occur to give a hint about broken Internet connection.
      * Do not use this method for errors known for sure thrown because of a bad proxy configuration.
-     * 
+     *
      * @param url The accessed URL that caused the error
      * @param t The network error
@@ -1441 +1463 @@
      * Adds a new network error that occur to give a hint about broken Internet connection.
      * Do not use this method for errors known for sure thrown because of a bad proxy configuration.
-     * 
+     *
      * @param url The accessed URL that caused the error
      * @param t The network error

trunk/src/org/openstreetmap/josm/data/validation/OsmValidator.java

@@ -308 +308 @@
             initializeTests(getTests());
             testsInitialized = true;
-            final long elapsedTime = System.currentTimeMillis() - startTime;
-            Main.debug("Initializing validator tests completed in " + Utils.getDurationString(elapsedTime));
+            if (Main.isDebugEnabled()) {
+                final long elapsedTime = System.currentTimeMillis() - startTime;
+                Main.debug("Initializing validator tests completed in " + Utils.getDurationString(elapsedTime));
+            }
         }
     }

trunk/src/org/openstreetmap/josm/gui/MapStatus.java

@@ -259 +259 @@
                             wait(1000);
                         } catch (InterruptedException e) {
-                            // Occurs frequently during JOSM shutdown, log set to debug only
-                            Main.debug("InterruptedException in "+MapStatus.class.getSimpleName());
+                            // Occurs frequently during JOSM shutdown, log set to trace only
+                            Main.trace("InterruptedException in "+MapStatus.class.getSimpleName());
                         }
                         ms.modifiers = mouseState.modifiers;

trunk/src/org/openstreetmap/josm/io/OsmApi.java

@@ -687 +687 @@
                     errorHeader = activeConnection.getHeaderField("Error");
                     Main.error("Error header: " + errorHeader);
-                } else if (retCode != 200 && responseBody.length()>0) {
+                } else if (retCode != HttpURLConnection.HTTP_OK && responseBody.length()>0) {
                     Main.error("Error body: " + responseBody);
                 }
                 activeConnection.disconnect();
+
+                if (Main.isDebugEnabled()) {
+                    Main.debug("RESPONSE: "+ activeConnection.getHeaderFields());
+                }
 
                 errorHeader = errorHeader == null? null : errorHeader.trim();
@@ -723 +727 @@
                 }
                 throw new OsmTransferException(e);
-            } catch(IOException e){
+            } catch(IOException e) {
                 throw new OsmTransferException(e);
-            } catch(OsmTransferCanceledException e){
+            } catch(OsmTransferCanceledException e) {
                 throw e;
             } catch(OsmTransferException e) {

trunk/src/org/openstreetmap/josm/io/OsmServerReader.java

@@ -158 +158 @@
             }
             try {
-                Main.debug(activeConnection.getHeaderFields().toString());
+                if (Main.isDebugEnabled()) {
+                    Main.debug("RESPONSE: "+activeConnection.getHeaderFields());
+                }
                 if (activeConnection.getResponseCode() == HttpURLConnection.HTTP_UNAUTHORIZED)
                     throw new OsmApiException(HttpURLConnection.HTTP_UNAUTHORIZED,null,null);

trunk/src/org/openstreetmap/josm/tools/Utils.java

@@ -749 +749 @@
             connection.setRequestProperty("Connection", "close");
         }
+        if (Main.isDebugEnabled()) {
+            try {
+                Main.debug("REQUEST: "+ connection.getRequestProperties());
+            } catch (IllegalStateException e) {
+                Main.warn(e);
+            }
+        }
         return connection;
     }