Changeset 6484 in josm

Timestamp:

2013-12-17T15:56:05+01:00 (11 years ago)

Author:

Don-vip

Message:

see #7307, fix #8474 - use org.json as lightweight internal json library (already being used by several plugins)

Location:

trunk/src/org

Files:

• json (added)
• json/JSONArray.java (added)
• json/JSONException.java (added)
• json/JSONObject.java (added)
• json/JSONString.java (added)
• json/JSONStringer.java (added)
• json/JSONTokener.java (added)
• json/JSONWriter.java (added)
• openstreetmap/josm/io/GeoJSONWriter.java (modified) (7 diffs)

trunk/src/org/openstreetmap/josm/io/GeoJSONWriter.java

@@ -4 +4 @@
 import java.util.Map;
 import java.util.Map.Entry;
+
+import org.json.JSONStringer;
 import org.openstreetmap.josm.data.coor.LatLon;
 import org.openstreetmap.josm.data.osm.Changeset;
@@ -16 +18 @@
 
     private OsmDataLayer layer;
-    private StringBuilder out;
+    private JSONStringer out;
     private static final boolean skipEmptyNodes = true;
-    private boolean insertComma = false;
 
     public GeoJSONWriter(OsmDataLayer layer) {
@@ -25 +26 @@
 
     public String write() {
-        out = new StringBuilder(1 << 12);
-        out.append("{\"type\": \"FeatureCollection\",\n");
-        out.append("\"features\": [\n");
+        out = new JSONStringer();
+        out.object().key("type").value("FeatureCollection");
+        out.key("features").array();
         for (Node n : layer.data.getNodes()) {
             appendPrimitive(n);
@@ -34 +35 @@
             appendPrimitive(w);
         }
-        out.append("\n]\n}");
+        out.endArray().endObject();
         return out.toString();
     }
@@ -40 +41 @@
     @Override
     public void visit(Node n) {
-        out.append("\"type\": \"Point\", \"coordinates\": ");
+        out.key("type").value("Point").key("coordinates");
         appendCoord(n.getCoor());
     }
@@ -46 +47 @@
     @Override
     public void visit(Way w) {
-        out.append("\"type\": \"LineString\", \"coordinates\": [");
-        boolean insertCommaCoords = false;
+        out.key("type").value("LineString").key("coordinates").array();
         for (Node n : w.getNodes()) {
-            if (insertCommaCoords) {
-                out.append(", ");
-            }
-            insertCommaCoords = true;
             appendCoord(n.getCoor());
         }
-        out.append("]");
+        out.endArray();
     }
 
@@ -76 +72 @@
             return;
         }
-        if (insertComma) {
-            out.append(",\n");
+        out.object().key("type").value("Feature");
+        Map<String, String> tags = p.getKeys();
+        out.key("properties").object();
+        for (Entry<String, String> t : tags.entrySet()) {
+            out.key(t.getKey()).value(t.getValue());
         }
-        insertComma = true;
-        out.append("{\"type\": \"Feature\",\n");
-        Map<String, String> tags = p.getKeys();
-        if (!tags.isEmpty()) {
-            out.append("\t\"properties\": {\n");
-            boolean insertCommaTags = false;
-            for (Entry<String, String> t : tags.entrySet()) {
-                if (insertCommaTags) {
-                    out.append(",\n");
-                }
-                insertCommaTags = true;
-                out.append("\t\t\"").append(escape(t.getKey())).append("\": ");
-                out.append("\"").append(escape(t.getValue())).append("\"");
-            }
-            out.append("\n\t},\n");
-        } else {
-            out.append("\t\"properties\": {},\n");
-        }
-        { // append primitive specific
-            out.append("\t\"geometry\": {");
-            p.accept(this);
-            out.append("}");
-        }
-        out.append("}");
+        out.endObject();
+        // append primitive specific
+        out.key("geometry").object();
+        p.accept(this);
+        out.endObject();
+        out.endObject();
     }
 
     protected void appendCoord(LatLon c) {
         if (c != null) {
-            out.append("[").append(c.lon()).append(", ").append(c.lat()).append("]");
+            out.array().value(c.lon()).value(c.lat()).endArray();
         }
     }