Changeset 6447 in josm for trunk

Timestamp:

2013-12-06T21:39:44+01:00 (11 years ago)

Author:

Don-vip

Message:

fix #9365 - validator: test and remove layer=0

File:

• trunk/src/org/openstreetmap/josm/data/validation/tests/DeprecatedTags.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/data/validation/tests/DeprecatedTags.java

@@ -23 +23 @@
 
 /**
- * Checks and corrects deprecated tags.
+ * Checks and corrects deprecated and unnecessary tags.
  * @since 4442
  */
@@ -140 +140 @@
                 test("monitoring:river_level").
                 alternative("monitoring:water_level"));
+        // see #9365 - Useless tag layer=0
+        checks.add(new UnnecessaryTagCheck(2130).
+                testAndRemove("layer", "0"));
     }
 
@@ -172 +175 @@
 
         private int code;
-        private final List<Tag> test = new LinkedList<Tag>();
-        private final List<Tag> change = new LinkedList<Tag>();
-        private final List<Tag> alternatives = new LinkedList<Tag>();
+        protected final List<Tag> test = new LinkedList<Tag>();
+        protected final List<Tag> change = new LinkedList<Tag>();
+        protected final List<Tag> alternatives = new LinkedList<Tag>();
 
         public DeprecationCheck(int code) {
@@ -242 +245 @@
         }
     }
+    
+    private static class UnnecessaryTagCheck extends DeprecationCheck {
+
+        public UnnecessaryTagCheck(int code) {
+            super(code);
+        }
+
+        @Override
+        String getDescription() {
+            return tr("{0} is unnecessary", Utils.join(", ", test));
+        }
+    }
 
     private class DeprecationError extends TestError {