Changeset 6425 in josm for trunk/src/org/openstreetmap

Timestamp:

2013-11-29T20:46:07+01:00 (11 years ago)

Author:

simon04

Message:

see #9309 - presets: make selected combo/multiselect values searchable/findable via F3

Location:

trunk/src/org/openstreetmap/josm/gui/tagging

Files:

• TaggingPresetItems.java (modified) (1 diff)
• TaggingPresetSelector.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPresetItems.java

@@ -865 +865 @@
         public String delimiter = ";";
         public String use_last_as_default = "false";
+        /** whether to use values for search via {@link TaggingPresetSelector} */
+        public String values_searchable = "false";
 
         protected JComponent component;

trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPresetSelector.java

@@ -123 +123 @@
             TaggingPreset group = preset.group;
             while (group != null) {
-                for (String word: group.getLocaleName().toLowerCase().split("\\s")) {
-                    groups.add(word);
-                }
+                Collections.addAll(groups, group.getLocaleName().toLowerCase().split("\\s"));
                 group = group.group;
             }
-            for (String word: preset.getLocaleName().toLowerCase().split("\\s")) {
-                names.add(word);
-            }
+            Collections.addAll(names, preset.getLocaleName().toLowerCase().split("\\s"));
             for (TaggingPresetItem item: preset.data) {
                 if (item instanceof KeyedItem) {
                     tags.add(((KeyedItem) item).key);
-                    // Should combo values also be added?
+                    if (item instanceof TaggingPresetItems.ComboMultiSelect) {
+                        final TaggingPresetItems.ComboMultiSelect cms = (TaggingPresetItems.ComboMultiSelect) item;
+                        if (Boolean.parseBoolean(cms.values_searchable)) {
+                            tags.addAll(cms.getDisplayValues());
+                        }
+                    }
                     if (item instanceof Key && ((Key) item).value != null) {
                         tags.add(((Key) item).value);
@@ -152 +153 @@
                 boolean foundFirst = false;
                 for (String value: values) {
-                    int index = value.indexOf(word);
+                    int index = value.toLowerCase().indexOf(word);
                     if (index == 0) {
                         foundFirst = true;