Changeset 6403 in josm for trunk

Timestamp:

2013-11-23T14:21:45+01:00 (11 years ago)

Author:

Don-vip

Message:

fix #9352 - find icon in presets for recent added tags if none is defined in map paint styles

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• dialogs/properties/PresetListPanel.java (modified) (1 diff)
• dialogs/properties/TagEditHelper.java (modified) (3 diffs)
• tagging/TaggingPreset.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/PresetListPanel.java

@@ -92 +92 @@
         for (TaggingPreset t : TaggingPreset.getMatchingPresets(types, tags, true)) {
             JLabel lbl = new JLabel(t.getName() + " …");
-            lbl.setIcon((Icon) t.getValue(Action.SMALL_ICON));
+            lbl.setIcon(t.getIcon());
             lbl.addMouseListener(new PresetLabelML(lbl, t, presetHandler));
             add(lbl, GBC.eol().fill(GBC.HORIZONTAL));

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/TagEditHelper.java

@@ -68 +68 @@
 import org.openstreetmap.josm.gui.ExtendedDialog;
 import org.openstreetmap.josm.gui.mappaint.MapPaintStyles;
+import org.openstreetmap.josm.gui.tagging.TaggingPreset;
 import org.openstreetmap.josm.gui.tagging.ac.AutoCompletingComboBox;
 import org.openstreetmap.josm.gui.tagging.ac.AutoCompletionListItem;
@@ -670 +671 @@
                 ImageIcon icon = MapPaintStyles.getNodeIcon(t, false); // Filters deprecated icon
                 if (icon == null) {
-                    icon = new ImageIcon(new BufferedImage(16, 16, BufferedImage.TYPE_INT_ARGB));
+                    // If no icon found in map style look at presets
+                    Map<String, String> map = new HashMap<String, String>();
+                    map.put(t.getKey(), t.getValue());
+                    for (TaggingPreset tp : TaggingPreset.getMatchingPresets(null, map, false)) {
+                        icon = tp.getIcon();
+                        if (icon != null) {
+                            break;
+                        }
+                    }
+                    // If still nothing display an empty icon
+                    if (icon == null) {
+                        icon = new ImageIcon(new BufferedImage(16, 16, BufferedImage.TYPE_INT_ARGB));
+                    }
                 }
                 GridBagConstraints gbc = new GridBagConstraints();
@@ -723 +736 @@
         }
 
-
         /**
          * Read tags from comboboxes and add it to all selected objects

trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPreset.java

@@ -123 +123 @@
         return group != null ? group.getRawName() + "/" + name : name;
     }
-
-    /*
+    
+    /**
+     * Returns the preset icon.
+     * @return The preset icon, or {@code null} if none defined
+     * @since 6403
+     */
+    public final ImageIcon getIcon() {
+        Object icon = getValue(Action.SMALL_ICON);
+        if (icon instanceof ImageIcon) {
+            return (ImageIcon) icon;
+        }
+        return null;
+    }
+
+    /**
      * Called from the XML parser to set the icon.
      * This task is performed in the background in order to speedup startup.
@@ -156 +169 @@
     }
 
-    /*
+    /**
      * Called from the XML parser to set the types this preset affects.
      */