Changeset 6335 in josm for trunk

Timestamp:

2013-10-27T04:23:57+01:00 (11 years ago)

Author:

Don-vip

Message:

Sonar/Findbugs - Unused Private Fields

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• oauth/FullyAutomaticPropertiesPanel.java (modified) (2 diffs)
• preferences/SourceEditor.java (modified) (1 diff)
• preferences/shortcut/PrefJPanel.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/oauth/FullyAutomaticPropertiesPanel.java

@@ -9 +9 @@
 
 import javax.swing.BorderFactory;
-import javax.swing.JCheckBox;
 import javax.swing.JLabel;
 import javax.swing.JPanel;
@@ -23 +22 @@
     private JosmTextField tfUserName;
     private JosmPasswordField tfPassword;
-
-    private JCheckBox cbWriteMapData;
-    private JCheckBox cbWriteGpsTraces;
-    private JCheckBox cbReadGpsTraces;
-
 
     protected JPanel buildUserNamePasswordPanel() {

trunk/src/org/openstreetmap/josm/gui/preferences/SourceEditor.java

@@ -1500 +1500 @@
     abstract public static class SourcePrefHelper {
 
-        private final String prefOld;
         private final String pref;
 
         public SourcePrefHelper(String pref, String prefOld) {
             this.pref = pref;
-            this.prefOld = prefOld;
         }
 

trunk/src/org/openstreetmap/josm/gui/preferences/shortcut/PrefJPanel.java

@@ -57 +57 @@
     // table of shortcuts
     private AbstractTableModel model;
-    // comboboxes of modifier groups, mapping selectedIndex to real data
-    private static int[] modifInts = new int[]{
-        -1,
-        0,
-        KeyEvent.SHIFT_DOWN_MASK,
-        KeyEvent.CTRL_DOWN_MASK,
-        KeyEvent.ALT_DOWN_MASK,
-        KeyEvent.META_DOWN_MASK,
-        KeyEvent.CTRL_DOWN_MASK | KeyEvent.SHIFT_DOWN_MASK,
-        KeyEvent.ALT_DOWN_MASK | KeyEvent.SHIFT_DOWN_MASK,
-        KeyEvent.META_DOWN_MASK | KeyEvent.SHIFT_DOWN_MASK,
-        KeyEvent.CTRL_DOWN_MASK | KeyEvent.ALT_DOWN_MASK,
-        KeyEvent.CTRL_DOWN_MASK | KeyEvent.META_DOWN_MASK,
-        KeyEvent.ALT_DOWN_MASK | KeyEvent.META_DOWN_MASK,
-        KeyEvent.CTRL_DOWN_MASK | KeyEvent.SHIFT_DOWN_MASK | KeyEvent.ALT_DOWN_MASK,
-        KeyEvent.META_DOWN_MASK | KeyEvent.SHIFT_DOWN_MASK | KeyEvent.ALT_DOWN_MASK
-    };
-    // and here are the texts fro the comboboxes
-    private static String[] modifList = new String[] {
-        tr("disabled"),
-        tr("no modifier"),
-        KeyEvent.getKeyModifiersText(KeyStroke.getKeyStroke(KeyEvent.VK_A, modifInts[2]).getModifiers()),
-        KeyEvent.getKeyModifiersText(KeyStroke.getKeyStroke(KeyEvent.VK_A, modifInts[3]).getModifiers()),
-        KeyEvent.getKeyModifiersText(KeyStroke.getKeyStroke(KeyEvent.VK_A, modifInts[4]).getModifiers()),
-        KeyEvent.getKeyModifiersText(KeyStroke.getKeyStroke(KeyEvent.VK_A, modifInts[5]).getModifiers()),
-        KeyEvent.getKeyModifiersText(KeyStroke.getKeyStroke(KeyEvent.VK_A, modifInts[6]).getModifiers()),
-        KeyEvent.getKeyModifiersText(KeyStroke.getKeyStroke(KeyEvent.VK_A, modifInts[7]).getModifiers()),
-        KeyEvent.getKeyModifiersText(KeyStroke.getKeyStroke(KeyEvent.VK_A, modifInts[8]).getModifiers()),
-        KeyEvent.getKeyModifiersText(KeyStroke.getKeyStroke(KeyEvent.VK_A, modifInts[9]).getModifiers()),
-        KeyEvent.getKeyModifiersText(KeyStroke.getKeyStroke(KeyEvent.VK_A, modifInts[10]).getModifiers()),
-        KeyEvent.getKeyModifiersText(KeyStroke.getKeyStroke(KeyEvent.VK_A, modifInts[11]).getModifiers()),
-        KeyEvent.getKeyModifiersText(KeyStroke.getKeyStroke(KeyEvent.VK_A, modifInts[12]).getModifiers()),
-        KeyEvent.getKeyModifiersText(KeyStroke.getKeyStroke(KeyEvent.VK_A, modifInts[13]).getModifiers())
-    };
     // this are the display(!) texts for the checkboxes. Let the JVM do the i18n for us <g>.
     // Ok, there's a real reason for this: The JVM should know best how the keys are labelled
@@ -140 +106 @@
 
     /** Creates new form prefJPanel */
-    // Ain't those auto-generated comments helpful or what? <g>
     public PrefJPanel(AbstractTableModel model) {
         this.model = model;