Changeset 6268 in josm for trunk/test/functional/org/openstreetmap

Timestamp:

2013-09-27T19:50:29+02:00 (11 years ago)

Author:

Don-vip

Message:

Sonar/FindBugs - Bad practice - Method may fail to close stream

Location:

trunk/test/functional/org/openstreetmap/josm

Files:

• gui/history/HistoryBrowserTest.java (modified) (3 diffs)
• io/MultiFetchServerObjectReaderTest.java (modified) (2 diffs)
• io/OsmServerBackreferenceReaderTest.java (modified) (2 diffs)

trunk/test/functional/org/openstreetmap/josm/gui/history/HistoryBrowserTest.java

@@ -6 +6 @@
 import java.awt.BorderLayout;
 import java.io.File;
+import java.io.InputStream;
 import java.text.MessageFormat;
 import java.util.Properties;
@@ -37 +38 @@
         //
         try {
-            testProperties.load(HistoryBrowserTest.class.getResourceAsStream("/test-functional-env.properties"));
+            InputStream is = HistoryBrowserTest.class.getResourceAsStream("/test-functional-env.properties");
+            testProperties.load(is);
+            is.close();
         } catch(Exception e){
             logger.log(Level.SEVERE, MessageFormat.format("failed to load property file ''{0}''", "test-functional-env.properties"));
@@ -83 +86 @@
     }
 
+    /**
+     * Constructs a new {@code HistoryBrowserTest}.
+     */
     public HistoryBrowserTest(){
         build();

trunk/test/functional/org/openstreetmap/josm/io/MultiFetchServerObjectReaderTest.java

@@ -12 +12 @@
 import java.io.FileWriter;
 import java.io.IOException;
+import java.io.InputStream;
 import java.io.PrintWriter;
 import java.text.MessageFormat;
@@ -138 +139 @@
         //
         try {
-            testProperties.load(MultiFetchServerObjectReaderTest.class.getResourceAsStream("/test-functional-env.properties"));
+            InputStream is = MultiFetchServerObjectReaderTest.class.getResourceAsStream("/test-functional-env.properties");
+            testProperties.load(is);
+            is.close();
         } catch(Exception e){
             logger.log(Level.SEVERE, MessageFormat.format("failed to load property file ''{0}''", "test-functional-env.properties"));

trunk/test/functional/org/openstreetmap/josm/io/OsmServerBackreferenceReaderTest.java

@@ -10 +10 @@
 import java.io.FileWriter;
 import java.io.IOException;
+import java.io.InputStream;
 import java.io.PrintWriter;
 import java.text.MessageFormat;
@@ -145 +146 @@
         //
         try {
-            testProperties.load(MultiFetchServerObjectReaderTest.class.getResourceAsStream("/test-functional-env.properties"));
+            InputStream is = MultiFetchServerObjectReaderTest.class.getResourceAsStream("/test-functional-env.properties");
+            testProperties.load(is);
+            is.close();
         } catch(Exception e){
             logger.log(Level.SEVERE, MessageFormat.format("failed to load property file ''{0}''", "test-functional-env.properties"));