Changeset 6264 in josm for trunk/test

Timestamp:

2013-09-27T01:16:28+02:00 (11 years ago)

Author:

Don-vip

Message:

Sonar/FindBugs - Performance - Method concatenates strings using + in a loop

Location:

trunk/test

Files:

• functional/org/openstreetmap/josm/gui/conflict/pair/nodes/NodeListMergerTest.java (modified) (1 diff)
• unit/org/openstreetmap/josm/data/projection/SwissGridTest.java (modified) (1 diff)

trunk/test/functional/org/openstreetmap/josm/gui/conflict/pair/nodes/NodeListMergerTest.java

@@ -23 +23 @@
             n1.put("key" + i, "value" + i);
         }
-        String note = "";
+        StringBuilder note = new StringBuilder();
         for (int i=0; i < 50; i++) {
-            note += " A very long text ";
+            note.append(" A very long text ");
         }
-        n1.put("note", note);
+        n1.put("note", note.toString());
         w1.addNode(new Node(2));
         w1.addNode(new Node(3));

trunk/test/unit/org/openstreetmap/josm/data/projection/SwissGridTest.java

@@ -48 +48 @@
     public void projReferenceTest() {
         Projection swiss = Projections.getProjectionByCode("EPSG:21781"); // Swiss grid
-        String errs = "";
+        StringBuilder errs = new StringBuilder();
         for (ProjData pd : data) {
             EastNorth en2 = swiss.latlon2eastNorth(pd.ll);
             if (Math.abs(pd.en.east() - en2.east()) > EPSILON || Math.abs(pd.en.north() - en2.north()) > EPSILON) {
-                errs += String.format("%s should be: %s but is: %s\n", pd.name, pd.en, en2);
-            }
-        }
-        assertTrue(errs, errs.length() == 0);
+                errs.append(String.format("%s should be: %s but is: %s\n", pd.name, pd.en, en2));
+            }
+        }
+        assertTrue(errs.toString(), errs.length() == 0);
     }