Changeset 6230 in josm for trunk/src/org/openstreetmap

Timestamp:

2013-09-11T00:41:49+02:00 (11 years ago)

Author:

Don-vip

Message:

Sonar - Don't create instances of already existing BigInteger ZERO

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/AlignInCircleAction.java (modified) (2 diffs)
• tools/Geometry.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/AlignInCircleAction.java

@@ -38 +38 @@
 public final class AlignInCircleAction extends JosmAction {
 
+    /**
+     * Constructs a new {@code AlignInCircleAction}.
+     */
     public AlignInCircleAction() {
         super(tr("Align Nodes in Circle"), "aligncircle", tr("Move the selected nodes into a circle."),
@@ -151 +154 @@
             // First calculate the average point
 
-            BigDecimal east = new BigDecimal(0);
-            BigDecimal north = new BigDecimal(0);
+            BigDecimal east = BigDecimal.ZERO;
+            BigDecimal north = BigDecimal.ZERO;
 
             for (Node n : nodes) {

trunk/src/org/openstreetmap/josm/tools/Geometry.java

@@ -654 +654 @@
     }
 
+    /**
+     * Compute the centroid of nodes
+     * @param nodes Nodes for which the centroid is wanted
+     * @return the centroid of nodes
+     */
     public static EastNorth getCentroid(List<Node> nodes) {
-        // Compute the centroid of nodes
-
-        BigDecimal area = new BigDecimal(0);
-        BigDecimal north = new BigDecimal(0);
-        BigDecimal east = new BigDecimal(0);
+
+        BigDecimal area = BigDecimal.ZERO;
+        BigDecimal north = BigDecimal.ZERO;
+        BigDecimal east = BigDecimal.ZERO;
 
         // See http://en.wikipedia.org/w/index.php?title=Centroid&oldid=294224857#Centroid_of_polygon for the equation used here