Changeset 5865 in josm

Timestamp:

2013-04-14T23:32:18+02:00 (11 years ago)

Author:

stoecker

Message:

fix user agent handling a bit (applet code now sets user agent

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/Preferences.java (modified) (3 diffs)
• gui/MainApplet.java (modified) (2 diffs)
• gui/io/TagSettingsPanel.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/Preferences.java

@@ -315 +315 @@
             cacheDirFile = new File(path).getAbsoluteFile();
         } else {
-            path = Main.pref.get("cache.folder", null);
+            path = get("cache.folder", null);
             if (path != null) {
                 cacheDirFile = new File(path);
@@ -339 +339 @@
     public Collection<String> getAllPossiblePreferenceDirs() {
         LinkedList<String> locations = new LinkedList<String>();
-        locations.add(Main.pref.getPreferencesDir());
+        locations.add(getPreferencesDir());
         String s;
         if ((s = System.getenv("JOSM_RESOURCES")) != null) {
@@ -1319 +1319 @@
     public void updateSystemProperties() {
         updateSystemProperty("http.agent", Version.getInstance().getAgentString());
-        updateSystemProperty("user.language", Main.pref.get("language"));
+        updateSystemProperty("user.language", get("language"));
         // Workaround to fix a Java bug.
         // Force AWT toolkit to update its internal preferences (fix #3645).

trunk/src/org/openstreetmap/josm/gui/MainApplet.java

@@ -102 +102 @@
         String lang = getParameter("language");
         I18n.set(lang != null ? lang : Main.pref.get("language", null));
+        Main.pref.updateSystemProperties();
 
         try
@@ -132 +133 @@
 
         Main.preConstructorInit(Option.fromStringMap(args));
+        Main.pref.updateSystemProperties();
         Main.parent = frame;
 

trunk/src/org/openstreetmap/josm/gui/io/TagSettingsPanel.java

@@ -13 +13 @@
 
 import org.openstreetmap.josm.Main;
+import org.openstreetmap.josm.data.Version;
 import org.openstreetmap.josm.data.osm.Changeset;
 import org.openstreetmap.josm.gui.tagging.TagEditorPanel;
@@ -44 +45 @@
         build();
         pnlTagEditor.getModel().addTableModelListener(this);
-    }
-
-    /**
-     * Replies the default value for "created_by"
-     *
-     * @return the default value for "created_by"
-     */
-    public static String getDefaultCreatedBy() {
-        Object ua = System.getProperties().get("http.agent");
-        return(ua == null) ? "JOSM" : ua.toString();
     }
 
@@ -93 +84 @@
             tags.put("comment", currentComment);
         }
+        String agent = Version.getInstance().getAgentString();
         String created_by = tags.get("created_by");
-        if (created_by == null || "".equals(created_by)) {
-            tags.put("created_by", getDefaultCreatedBy());
-        } else if (!created_by.contains(getDefaultCreatedBy())) {
-            tags.put("created_by", created_by + ";" + getDefaultCreatedBy());
+        if (created_by == null || created_by.isEmpty()) {
+            tags.put("created_by", agent);
+        } else if (!created_by.contains(agent)) {
+            tags.put("created_by", created_by + ";" + agent);
         }
         pnlTagEditor.getModel().initFromTags(tags);