Changeset 5759 in josm for trunk/src/org

Timestamp:

2013-03-06T22:41:42+01:00 (12 years ago)

Author:

Don-vip

Message:

fix NPE if a SequenceCommand is created before an edit layer exists + fix warnings in Command class

File:

• trunk/src/org/openstreetmap/josm/command/Command.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/command/Command.java

@@ -1 +1 @@
 //License: GPL. Copyright 2007 by Immanuel Scholz and others
 package org.openstreetmap.josm.command;
-
-import static org.openstreetmap.josm.tools.I18n.tr;
 
 import java.awt.GridBagLayout;
@@ -16 +14 @@
 import javax.swing.JOptionPane;
 import javax.swing.JPanel;
-import javax.swing.tree.DefaultMutableTreeNode;
-import javax.swing.tree.MutableTreeNode;
 
 import org.openstreetmap.josm.Main;
@@ -59 +55 @@
 
     /** the layer which this command is applied to */
-    private OsmDataLayer layer;
-
+    private final OsmDataLayer layer;
+
+    /**
+     * Creates a new command in the context of the current edit layer, if any
+     */
     public Command() {
-        this.layer = Main.map.mapView.getEditLayer();
+        this.layer = Main.map != null && Main.map.mapView != null ? Main.map.mapView.getEditLayer() : null;
     }
 
@@ -79 +78 @@
      * Executes the command on the dataset. This implementation will remember all
      * primitives returned by fillModifiedData for restoring them on undo.
+     * @return true
      */
     public boolean executeCommand() {
@@ -124 +124 @@
      * Lets other commands access the original version
      * of the object. Usually for undoing.
+     * @param osm The requested OSM object
+     * @return The original version of the requested object, if any
      */
     public PrimitiveData getOrig(OsmPrimitive osm) {
-        PrimitiveData o = cloneMap.get(osm);
-        if (o != null)
-            return o;
-        for (OsmPrimitive t : cloneMap.keySet()) {
-            PrimitiveData to = cloneMap.get(t);
-        }
-        return o;
+        return cloneMap.get(osm);
     }