Changeset 5448 in josm for trunk/src

Timestamp:

2012-08-15T17:11:43+02:00 (12 years ago)

Author:

Don-vip

Message:

Prevents MapView from being repainted multiple times when adding the first active layer

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• MapFrame.java (modified) (1 diff)
• MapView.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/MapFrame.java

@@ -627 +627 @@
             }
         }
-        if (!modeChanged && mapMode != null) {
-            // Let mapmodes know about new active layer
-            mapMode.exitMode();
-            mapMode.enterMode();
-        }
-        // invalidate repaint cache
-        Main.map.mapView.preferenceChanged(null);
+        // if this is really a change (and not the first active layer)
+        if (oldLayer != null) {
+            if (!modeChanged && mapMode != null) {
+                // Let mapmodes know about new active layer
+                mapMode.exitMode();
+                mapMode.enterMode();
+            }
+            // invalidate repaint cache
+            Main.map.mapView.preferenceChanged(null);
+        }
 
         // After all listeners notice new layer, some buttons will be disabled/enabled

trunk/src/org/openstreetmap/josm/gui/MapView.java

@@ -319 +319 @@
         }
         fireLayerAdded(layer);
-        if (layer instanceof OsmDataLayer || activeLayer == null) {
+        boolean callSetActiveLayer = layer instanceof OsmDataLayer || activeLayer == null;
+        if (callSetActiveLayer) {
             // autoselect the new layer
-            setActiveLayer(layer);
+            setActiveLayer(layer); // also repaints this MapView
         }
         layer.addPropertyChangeListener(this);
         Main.addProjectionChangeListener(layer);
         AudioPlayer.reset();
-        repaint();
+        if (!callSetActiveLayer) {
+            repaint();
+        }
     }