Changeset 4563 in josm

Timestamp:

2011-11-02T10:34:30+01:00 (13 years ago)

Author:

stoecker

Message:

fix #6880 - patch by Bernhard Hiller - Ask for confirmation when closing relation editor

File:

• trunk/src/org/openstreetmap/josm/gui/dialogs/relation/GenericRelationEditor.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/gui/dialogs/relation/GenericRelationEditor.java

@@ -68 +68 @@
 import org.openstreetmap.josm.gui.DefaultNameFormatter;
 import org.openstreetmap.josm.gui.HelpAwareOptionPane;
+import org.openstreetmap.josm.gui.SideButton;
 import org.openstreetmap.josm.gui.HelpAwareOptionPane.ButtonSpec;
-import org.openstreetmap.josm.gui.SideButton;
 import org.openstreetmap.josm.gui.dialogs.properties.PresetListPanel.PresetHandler;
 import org.openstreetmap.josm.gui.help.ContextSensitiveHelpAction;
@@ -1118 +1118 @@
                 @Override
                 public void run() {
-                        // Relation list gets update in EDT so selecting my be postponed to following EDT run
+                    // Relation list gets update in EDT so selecting my be postponed to following EDT run
                     Main.map.relationListDialog.selectRelation(newRelation);
                 }
@@ -1268 +1268 @@
     }
 
-    class CancelAction extends AbstractAction {
+    class CancelAction extends SavingAction {
         public CancelAction() {
             putValue(SHORT_DESCRIPTION, tr("Cancel the updates and close the dialog"));
@@ -1281 +1281 @@
 
         public void actionPerformed(ActionEvent e) {
+            if (!memberTableModel.hasSameMembersAs(getRelationSnapshot()) || tagEditorPanel.getModel().isDirty()) {
+                //give the user a chance to save the changes
+                int ret = confirmClosingByCancel();
+                if (ret == 0) { //Yes, save the changes
+                    //copied from OKAction.run()
+                    Main.pref.put("relation.editor.generic.lastrole", tfRole.getText());
+                    if (getRelation() == null) {
+                        applyNewRelation();
+                    } else if (!memberTableModel.hasSameMembersAs(getRelationSnapshot())
+                            || tagEditorPanel.getModel().isDirty()) {
+                        if (isDirtyRelation()) {
+                            if (confirmClosingBecauseOfDirtyState()) {
+                                if (getLayer().getConflicts().hasConflictForMy(getRelation())) {
+                                    warnDoubleConflict();
+                                    return;
+                                }
+                                applyExistingConflictingRelation();
+                            } else
+                                return;
+                        } else {
+                            applyExistingNonConflictingRelation();
+                        }
+                    }
+                }
+                else if (ret == 2) //Cancel, continue editing
+                    return;
+                //in case of "No, discard", there is no extra action to be performed here.
+            }
             setVisible(false);
+        }
+
+        protected int confirmClosingByCancel() {
+            ButtonSpec [] options = new ButtonSpec[] {
+                    new ButtonSpec(
+                            tr("Yes, save the changes and close"),
+                            ImageProvider.get("ok"),
+                            tr("Click to save the changes and close this relation editor") ,
+                            null /* no specific help topic */
+                    ),
+                    new ButtonSpec(
+                            tr("No, discard the changes and close"),
+                            ImageProvider.get("cancel"),
+                            tr("Click to discard the changes and close this relation editor") ,
+                            null /* no specific help topic */
+                    ),
+                    new ButtonSpec(
+                            tr("Cancel, continue editing"),
+                            ImageProvider.get("cancel"),
+                            tr("Click to return to the relation editor and to resume relation editing") ,
+                            null /* no specific help topic */
+                    )
+            };
+
+            int ret = HelpAwareOptionPane.showOptionDialog(
+                    Main.parent,
+                    tr("<html>The relation has been changed.<br>"
+                            + "<br>"
+                            + "Do you want to save your changes?</html>"),
+                            tr("Unsaved changes"),
+                            JOptionPane.WARNING_MESSAGE,
+                            null,
+                            options,
+                            options[0], // OK is default,
+                            "/Dialog/RelationEditor#DiscardChanges"
+            );
+            return ret;
         }
     }