Changeset 4018 in josm

Timestamp:

2011-04-06T19:09:47+02:00 (14 years ago)

Author:

bastiK

Message:

applied #6187 - Search GUI improvements (patch by bilbo)

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/search/SearchAction.java (modified) (4 diffs)
• gui/tagging/ac/AutoCompletingComboBox.java (modified) (1 diff)
• gui/widgets/HistoryComboBox.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/search/SearchAction.java

@@ -43 +43 @@
 public class SearchAction extends JosmAction implements ParameterizedAction {
 
-    public static final int DEFAULT_SEARCH_HISTORY_SIZE = 10;
+    public static final int DEFAULT_SEARCH_HISTORY_SIZE = 15;
 
     private static final String SEARCH_EXPRESSION = "searchExpression";
@@ -136 +136 @@
         // -- prepare the combo box with the search expressions
         //
-        JLabel label = new JLabel( initialValues instanceof Filter ? tr("Please enter a filter string.") : tr("Please enter a search string."));
+        JLabel label = new JLabel( initialValues instanceof Filter ? tr("Filter string:") : tr("Search string:"));
         final HistoryComboBox hcbSearchString = new HistoryComboBox();
         hcbSearchString.setText(initialValues.text);
@@ -165 +165 @@
         final JCheckBox regexSearch   = new JCheckBox(tr("regular expression"), initialValues.regexSearch);
 
+        JPanel top = new JPanel(new GridBagLayout());
+        top.add(label, GBC.std().insets(0, 0, 5, 0));
+        top.add(hcbSearchString, GBC.eol().fill(GBC.HORIZONTAL));
         JPanel left = new JPanel(new GridBagLayout());
-        left.add(label, GBC.eop());
-        left.add(hcbSearchString, GBC.eop().fill(GBC.HORIZONTAL));
         left.add(replace, GBC.eol());
         left.add(add, GBC.eol());
@@ -212 +213 @@
         right.add(description);
 
-        final JPanel p = new JPanel();
-        p.add(left);
-        p.add(right);
+        final JPanel p = new JPanel(new GridBagLayout());
+        p.add(top, GBC.eol().fill(GBC.HORIZONTAL).insets(5, 5, 5, 0));
+        p.add(left, GBC.std().anchor(GBC.NORTH).insets(5, 10, 10, 0));
+        p.add(right, GBC.eol());
         ExtendedDialog dialog = new ExtendedDialog(
                 Main.parent,

trunk/src/org/openstreetmap/josm/gui/tagging/ac/AutoCompletingComboBox.java

@@ -145 +145 @@
                 }
         );
+        int maxsize=Math.max(getMaximumRowCount(),java.awt.Toolkit.getDefaultToolkit().getScreenSize().height/getPreferredSize().height - 1);
+        setMaximumRowCount(maxsize);
     }
 

trunk/src/org/openstreetmap/josm/gui/widgets/HistoryComboBox.java

@@ -7 +7 @@
 
 import org.openstreetmap.josm.gui.tagging.ac.AutoCompletingComboBox;
+import org.openstreetmap.josm.Main;
 
 public class HistoryComboBox extends AutoCompletingComboBox {
     private ComboBoxHistory model;
 
+    public static final int DEFAULT_SEARCH_HISTORY_SIZE = 15;
+
     public HistoryComboBox() {
-        setModel(model = new ComboBoxHistory(15));
+        int maxsize = Main.pref.getInteger("search.history-size", DEFAULT_SEARCH_HISTORY_SIZE);
+        setModel(model = new ComboBoxHistory(maxsize));
         setEditable(true);
     }