Changeset 3965 in josm for trunk

Timestamp:

2011-03-09T00:03:07+01:00 (13 years ago)

Author:

mjulius

Message:

fix #6074 - Update failure
It is not an error if a primitive on the server is invisible while the local copy is not if the latter one is modified.
Catch DataIntegrityProblemException when merging.

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/osm/DataSetMerger.java (modified) (1 diff)
• gui/layer/OsmDataLayer.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/osm/DataSetMerger.java

@@ -309 +309 @@
             // take. We take target.
             //
-        } else if (target.isVisible() != source.isVisible() && target.getVersion() == source.getVersion())
-            // Same version, but different "visible" attribute. It indicates a serious problem in datasets.
+        } else if (!target.isModified() && !source.isModified() && target.isVisible() != source.isVisible() && target.getVersion() == source.getVersion())
+            // Same version, but different "visible" attribute and neither of them are modified.
+            // It indicates a serious problem in datasets.
             // For example, datasets can be fetched from different OSM servers or badly hand-modified.
             // We shouldn't merge that datasets.

trunk/src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java

@@ -47 +47 @@
 import org.openstreetmap.josm.data.gpx.ImmutableGpxTrack;
 import org.openstreetmap.josm.data.gpx.WayPoint;
+import org.openstreetmap.josm.data.osm.DataIntegrityProblemException;
 import org.openstreetmap.josm.data.osm.DataSet;
 import org.openstreetmap.josm.data.osm.DataSetMerger;
@@ -65 +66 @@
 import org.openstreetmap.josm.data.validation.TestError;
 import org.openstreetmap.josm.gui.HelpAwareOptionPane;
+import org.openstreetmap.josm.gui.HelpAwareOptionPane.ButtonSpec;
 import org.openstreetmap.josm.gui.MapView;
-import org.openstreetmap.josm.gui.HelpAwareOptionPane.ButtonSpec;
 import org.openstreetmap.josm.gui.dialogs.LayerListDialog;
 import org.openstreetmap.josm.gui.dialogs.LayerListPopup;
@@ -299 +300 @@
     public void mergeFrom(final DataSet from) {
         final DataSetMerger visitor = new DataSetMerger(data,from);
-        visitor.merge();
+        try {
+            visitor.merge();
+        } catch (DataIntegrityProblemException e) {
+            JOptionPane.showMessageDialog(
+                    Main.parent,
+                    e.getMessage(),
+                    tr("Error"),
+                    JOptionPane.ERROR_MESSAGE
+            );
+            return;
+
+        }
 
         Area a = data.getDataSourceArea();