Changeset 36339 in osm for applications/editors/josm/plugins

Timestamp:

2024-09-19T17:42:45+02:00 (3 weeks ago)

Author:

taylor.smock

Message:

Fix #20508: KWallet5 isn't working

This attempts to iterate through different KWallet versions

Location:

applications/editors/josm/plugins/native-password-manager

Files:

• build.xml (modified) (1 diff)
• pom.xml (modified) (1 diff)
• src/org/netbeans/modules/keyring/kde/KWalletProvider.java (modified) (9 diffs)

applications/editors/josm/plugins/native-password-manager/build.xml

@@ -5 +5 @@
     <property name="commit.message" value="Commit message"/>
     <!-- enter the *lowest* JOSM version this plugin is currently compatible with -->
-    <property name="plugin.main.version" value="18991"/>
+    <property name="plugin.main.version" value="19044"/>
     <property name="plugin.author" value="Paul Hartmann"/>
     <property name="plugin.class" value="org.openstreetmap.josm.plugins.npm.NPMPlugin"/>

applications/editors/josm/plugins/native-password-manager/pom.xml

@@ -17 +17 @@
     <properties>
         <plugin.src.dir>src</plugin.src.dir>
-        <plugin.main.version>18991</plugin.main.version>
+        <plugin.main.version>19044</plugin.main.version>
         <plugin.author>Paul Hartmann</plugin.author>
         <plugin.class>org.openstreetmap.josm.plugins.npm.NPMPlugin</plugin.class>

applications/editors/josm/plugins/native-password-manager/src/org/netbeans/modules/keyring/kde/KWalletProvider.java

@@ -62 +62 @@
     private char[] handler = "0".toCharArray();
     private boolean timeoutHappened = false;
-    private char[] defaultLocalWallet = "kdewallet".toCharArray();
+    private final char[] defaultLocalWallet = "kdewallet".toCharArray();
 
     @Override
@@ -100 +100 @@
                 warning("save action failed");
             }
-            return;
         }
         //throw new KwalletException("save");
@@ -113 +112 @@
                 warning("delete action failed");
             }
-            return;
         }
         //throw new KwalletException("delete");
@@ -122 +120 @@
             return false;
         }
-        handler = new String(handler).equals("")? "0".toCharArray() : handler;
+        handler = new String(handler).isEmpty() ? "0".toCharArray() : handler;
         CommandResult result = runCommand("isOpen",handler);          
         if(new String(result.retVal).equals("true")){
@@ -157 +155 @@
 
     private CommandResult runCommand(String command,char[]... commandArgs) {
+        CommandResult result = null;
+        for (int i : new int[] {6, 5, 0}) {
+            result = runCommandKdeVersion(i, command, commandArgs);
+            if (result.exitCode == 0 && !result.errVal.equals("Service 'org.kde.kwalletd" + (i != 0 ? i : "") + "' does not exist.")) {
+                break;
+            }
+        }
+        return result;
+    }
+
+    private CommandResult runCommandKdeVersion(int kdeVersion, String command, char[]... commandArgs) {
         String[] argv = new String[commandArgs.length+4];
         argv[0] = "qdbus";
-        argv[1] = "org.kde.kwalletd";
-        argv[2] = "/modules/kwalletd";
+        argv[1] = "org.kde.kwalletd" + (kdeVersion != 0 ? kdeVersion : "");
+        argv[2] = "/modules/kwalletd" + (kdeVersion != 0 ? kdeVersion : "");
         argv[3] = "org.kde.KWallet."+command;
         for (int i = 0; i < commandArgs.length; i++) {
-            //unfortunatelly I cannot pass char[] to the exec in any way - so this poses a security issue with passwords in String() !
+            //unfortunately I cannot pass char[] to the exec in any way - so this poses a security issue with passwords in String() !
             //TODO: find a way to avoid changing char[] into String
             argv[i+4] = new String(commandArgs[i]);
@@ -181 +190 @@
                 String line;
                 while((line = input.readLine()) != null) {
-                    if (!retVal.equals("")){
+                    if (!retVal.isEmpty()){
                         retVal = retVal.concat("\n");
                     }
@@ -191 +200 @@
                 String line;
                 while((line = input.readLine()) != null) {
-                    if (!errVal.equals("")){
+                    if (!errVal.isEmpty()){
                         errVal = errVal.concat("\n");
                     }
@@ -204 +213 @@
             }       
         } catch (InterruptedException ex) {
+            Thread.currentThread().interrupt();
             logger.log(Level.FINE,
                     "exception thrown while invoking the command \""+Arrays.toString(argv)+"\"",
@@ -224 +234 @@
   
     private static class CommandResult {
-        private int exitCode;
-        private char[] retVal;
+        private final int exitCode;
+        private final char[] retVal;
+        private final String errVal;
 
         public CommandResult(int exitCode, char[] retVal, String errVal) {
             this.exitCode = exitCode;
             this.retVal = retVal;
+            this.errVal = errVal;
         }                        
     }