Changeset 36280 in osm for applications/editors/josm/plugins/reltoolbox/src/relcontext

Timestamp:

2024-06-07T09:51:18+02:00 (5 months ago)

Author:

GerdP

Message:

fix #23715: Plugin Relation Toolbox began to remove multipuligons

• don't change member list to empty list if relation is not valid
• add/improve unit tests
• fix project files to allow running unit tests in Eclipse

File:

• applications/editors/josm/plugins/reltoolbox/src/relcontext/relationfix/MultipolygonFixer.java (modified) (1 diff)

applications/editors/josm/plugins/reltoolbox/src/relcontext/relationfix/MultipolygonFixer.java

@@ -50 +50 @@
     public Command fixRelation(Relation rel) {
         List<RelationMember> members = fixMultipolygonRoles(rel.getMembers());
-        if (!members.equals(rel.getMembers())) {
-            final DataSet ds = Utils.firstNonNull(rel.getDataSet(), MainApplication.getLayerManager().getEditDataSet());
-            return new ChangeMembersCommand(ds, rel, members);
-        }
-        return null;
+        if (members.isEmpty() || members.equals(rel.getMembers())) 
+            return null;
+        final DataSet ds = Utils.firstNonNull(rel.getDataSet(), MainApplication.getLayerManager().getEditDataSet());
+        return new ChangeMembersCommand(ds, rel, members);
     }