Changeset 36144 in osm for applications/editors/josm

Timestamp:

2023-09-18T20:32:00+02:00 (16 months ago)

Author:

taylor.smock

Message:

See #23111: Use the common acceptsDocumentationSummary DownloadTask method definition

Location:

applications/editors/josm/plugins/pmtiles

Files:

• build.xml (modified) (1 diff)
• src/main/java/org/openstreetmap/josm/plugins/pmtiles/actions/downloadtasks/DownloadPMTilesTask.java (modified) (2 diffs)

applications/editors/josm/plugins/pmtiles/build.xml

@@ -8 +8 @@
     <property name="commit.message" value="Commit message"/>
     <!-- enter the *lowest* JOSM version this plugin is currently compatible with -->
-    <property name="plugin.main.version" value="10580"/>
+    <property name="plugin.main.version" value="18830"/>
 
     <!-- Configure these properties (replace "..." accordingly).

applications/editors/josm/plugins/pmtiles/src/main/java/org/openstreetmap/josm/plugins/pmtiles/actions/downloadtasks/DownloadPMTilesTask.java

@@ -18 +18 @@
 import org.openstreetmap.josm.gui.MainApplication;
 import org.openstreetmap.josm.gui.progress.ProgressMonitor;
-import org.openstreetmap.josm.io.XmlWriter;
 import org.openstreetmap.josm.plugins.pmtiles.data.imagery.PMTilesImageryInfo;
 import org.openstreetmap.josm.plugins.pmtiles.gui.layers.PMTilesImageLayer;
@@ -74 +73 @@
 
     @Override
-    public String acceptsDocumentationSummary() {
-        // I think this should be a "default" implementation in DownloadTask
-        StringBuilder buff = new StringBuilder(128)
-                .append("<tr><td>")
-                .append(getTitle())
-                .append(":</td><td>");
-        String[] patterns = getPatterns();
-        if (patterns.length > 0) {
-            buff.append("<ul>");
-            for (String pattern: patterns) {
-                buff.append("<li>")
-                        .append(XmlWriter.encode(pattern))
-                        .append("</li>");
-            }
-            buff.append("</ul>");
-        }
-        buff.append("</td></tr>");
-        return buff.toString();
-    }
-
-    @Override
     public String getTitle() {
         return tr("Add PMTiles layer");