Changeset 36134 in osm for applications/editors/josm/plugins/addrinterpolation/src/org

Timestamp:

2023-09-07T18:20:01+02:00 (19 months ago)

Author:

taylor.smock

Message:

Use DeleteCommand.delete where possible and fix some potential NPEs from its usage

File:

• applications/editors/josm/plugins/addrinterpolation/src/org/openstreetmap/josm/plugins/AddrInterpolation/AddrInterpolationDialog.java (modified) (1 diff)

applications/editors/josm/plugins/addrinterpolation/src/org/openstreetmap/josm/plugins/AddrInterpolation/AddrInterpolationDialog.java

@@ -978 +978 @@
 
     private void removeAddressInterpolationWay() {
-
-        // Remove way - nodes of the way remain
-        commandGroup.add(DeleteCommand.delete(Collections.singleton(addrInterpolationWay)));
-
-        // Remove untagged nodes
-        for (int i = 1; i < addrInterpolationWay.getNodesCount()-1; i++) {
-            Node testNode = addrInterpolationWay.getNode(i);
-            if (!testNode.hasKeys()) {
-                commandGroup.add(DeleteCommand.delete(Collections.singleton(testNode)));
-            }
+        final Command deleteCommand = DeleteCommand.delete(Collections.singleton(addrInterpolationWay), true);
+        if (deleteCommand != null) {
+            commandGroup.add(deleteCommand);
         }