Changeset 36064 in osm for applications/editors/josm/plugins/print/test

Timestamp:

2023-03-21T14:49:10+01:00 (22 months ago)

Author:

taylor.smock

Message:

See #16567: Convert most plugin tests to JUnit 5

File:

• applications/editors/josm/plugins/print/test/unit/org/openstreetmap/josm/plugins/print/PrintDialogTest.java (modified) (4 diffs)

applications/editors/josm/plugins/print/test/unit/org/openstreetmap/josm/plugins/print/PrintDialogTest.java

@@ -2 +2 @@
 package org.openstreetmap.josm.plugins.print;
 
-import static org.junit.Assert.assertEquals;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
 
 import java.util.Arrays;
@@ -8 +9 @@
 import javax.print.attribute.standard.OrientationRequested;
 
-import org.junit.Ignore;
-import org.junit.Rule;
-import org.junit.Test;
-import org.openstreetmap.josm.testutils.JOSMTestRules;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+import org.openstreetmap.josm.testutils.annotations.BasicPreferences;
 
 /**
  * Unit test of {@link PrintDialog} class.
  */
-public class PrintDialogTest {
-
-    /**
-     * Setup test.
-     */
-    @Rule
-    public JOSMTestRules rules = new JOSMTestRules().preferences();
-
+@BasicPreferences
+class PrintDialogTest {
     /**
      * Unit test of {@link PrintDialog#unmarshallPrintSetting}
@@ -29 +23 @@
      */
     @Test
-    public void testUnmarshallPrintSetting() throws ReflectiveOperationException {
+    void testUnmarshallPrintSetting() throws ReflectiveOperationException {
         assertEquals(OrientationRequested.PORTRAIT, PrintDialog.unmarshallPrintSetting(Arrays.asList(
                 "javax.print.attribute.standard.OrientationRequested",
@@ -42 +36 @@
      */
     @Test
-    @Ignore("not fixed yet")
-    public void testTicket13302() throws ReflectiveOperationException {
+    @Disabled("not fixed yet")
+    void testTicket13302() throws ReflectiveOperationException {
         assertEquals(OrientationRequested.PORTRAIT, PrintDialog.unmarshallPrintSetting(Arrays.asList(
                 "javax.print.attribute.standard.MediaSizeName",