Changeset 35915 in osm for applications/editors

Timestamp:

2022-02-09T19:26:58+01:00 (3 years ago)

Author:

taylor.smock

Message:

buildings_tools: fix #9065, #19348

• #9065: Add new configuration option to always select new building
• #19348: Add preference for autoselect setting, which used to be forgotten on

JOSM restart

patch by Woazboat

Location:

applications/editors/josm/plugins/buildings_tools/src/org/openstreetmap/josm/plugins/buildings_tools

Files:

• BuildingSizeDialog.java (modified) (4 diffs)
• DrawBuildingAction.java (modified) (1 diff)
• ToolSettings.java (modified) (2 diffs)

applications/editors/josm/plugins/buildings_tools/src/org/openstreetmap/josm/plugins/buildings_tools/BuildingSizeDialog.java

@@ -22 +22 @@
     private final JCheckBox caddr = new JCheckBox(tr("Use Address dialog"));
     private final JCheckBox cAutoSelect = new JCheckBox(tr("Auto-select building"));
+    private final JCheckBox cAutoSelectReplaceSelection = new JCheckBox(tr("Auto-select replaces existing selection"));
     private final JCheckBox cAddrNode = new JCheckBox(tr("Use address nodes under buildings"));
     private final JRadioButton circleRadio = new JRadioButton(tr("Circle"));
@@ -42 +43 @@
         panel.add(caddr, GBC.eol().fill(GBC.HORIZONTAL));
         panel.add(cAutoSelect, GBC.eol().fill(GBC.HORIZONTAL));
+        panel.add(cAutoSelectReplaceSelection, GBC.eol().fill(GBC.HORIZONTAL));
         panel.add(cAddrNode, GBC.eol().fill(GBC.HORIZONTAL));
 
@@ -48 +50 @@
         caddr.setSelected(ToolSettings.isUsingAddr());
         cAutoSelect.setSelected(ToolSettings.isAutoSelect());
+        cAutoSelectReplaceSelection.setSelected(ToolSettings.isAutoSelectReplaceSelection());
         cAddrNode.setSelected(ToolSettings.PROP_USE_ADDR_NODE.get());
 
@@ -95 +98 @@
         ToolSettings.setAddrDialog(useAddr());
         ToolSettings.setAutoSelect(cAutoSelect.isSelected());
+        ToolSettings.setAutoSelectReplaceSelection(cAutoSelectReplaceSelection.isSelected());
         ToolSettings.PROP_USE_ADDR_NODE.put(cAddrNode.isSelected());
     }

applications/editors/josm/plugins/buildings_tools/src/org/openstreetmap/josm/plugins/buildings_tools/DrawBuildingAction.java

@@ -351 +351 @@
                     showAddrDialog(w);
                 if (ToolSettings.isAutoSelect()
-                        && (getLayerManager().getEditDataSet().getSelected().isEmpty() || shift)) {
+                        && (getLayerManager().getEditDataSet().getSelected().isEmpty() || shift ||
+                            ToolSettings.isAutoSelectReplaceSelection())) {
                     getLayerManager().getEditDataSet().setSelected(w);
                 }

applications/editors/josm/plugins/buildings_tools/src/org/openstreetmap/josm/plugins/buildings_tools/ToolSettings.java

@@ -31 +31 @@
     private static boolean useAddr;
     private static final Map<String, String> TAGS = new HashMap<>();
-    private static boolean autoSelect;
 
     public static Shape getShape() {
@@ -120 +119 @@
 
     public static boolean isAutoSelect() {
-        return autoSelect;
+        return Config.getPref().getBoolean("buildings_tools.autoselect", false);
     }
 
     public static void setAutoSelect(boolean autoSelect) {
-        ToolSettings.autoSelect = autoSelect;
+        Config.getPref().putBoolean("buildings_tools.autoselect", autoSelect);
+    }
+
+    public static boolean isAutoSelectReplaceSelection() {
+        return Config.getPref().getBoolean("buildings_tools.autoselect_replace_selection", false);
+    }
+
+    public static void setAutoSelectReplaceSelection(boolean autoSelectReplace) {
+        Config.getPref().putBoolean("buildings_tools.autoselect_replace_selection", autoSelectReplace);
     }