Changeset 35818 in osm for applications/editors/josm

Timestamp:

2021-09-24T08:14:42+02:00 (3 years ago)

Author:

GerdP

Message:

fix #21315: Using buildings_tools with a double click produces invalid buildings

File:

• applications/editors/josm/plugins/buildings_tools/src/org/openstreetmap/josm/plugins/buildings_tools/DrawBuildingAction.java (modified) (4 diffs)

applications/editors/josm/plugins/buildings_tools/src/org/openstreetmap/josm/plugins/buildings_tools/DrawBuildingAction.java

@@ -64 +64 @@
     private Point drawStartPos;
     private Point mousePos;
+    /** Force a reasonable dimension */
+    private static final double MIN_LEN_WIDTH = 1E-6;
 
     final transient Building building = new Building();
@@ -244 +246 @@
         if (isRectDrawing()) {
             building.setPlaceRect(p);
+            if (building.getLength() < MIN_LEN_WIDTH)
+                return Mode.Drawing;
             return shift ? Mode.DrawingAngFix : Mode.None;
         } else if (ToolSettings.Shape.CIRCLE == ToolSettings.getShape()) {
@@ -251 +255 @@
                 building.setPlace(p, ToolSettings.getWidth(), ToolSettings.getLenStep(), shift);
             }
+            if (building.getLength() < MIN_LEN_WIDTH)
+                return Mode.Drawing;
             MainApplication.getMap().statusLine.setDist(building.getLength());
-            this.nextMode = Mode.None;
-            return this.nextMode;
+            return Mode.None;
         } else {
             building.setPlace(p, ToolSettings.getWidth(), ToolSettings.getLenStep(), shift);
+            if (building.getLength() < MIN_LEN_WIDTH)
+                return Mode.Drawing;
             MainApplication.getMap().statusLine.setDist(building.getLength());
-            this.nextMode = ToolSettings.getWidth() == 0 ? Mode.DrawingWidth : Mode.None;
-            return this.nextMode;
+            return ToolSettings.getWidth() == 0 ? Mode.DrawingWidth : Mode.None;
         }
     }
@@ -264 +270 @@
     private Mode modeDrawingWidth() {
         building.setWidth(getEastNorth());
-        MainApplication.getMap().statusLine.setDist(Math.abs(building.getWidth()));
-        return Mode.None;
+        double width = Math.abs(building.getWidth());
+        MainApplication.getMap().statusLine.setDist(width);
+        return width < MIN_LEN_WIDTH ? Mode.DrawingWidth : Mode.None;
     }