Changeset 35814 in osm

Timestamp:

2021-08-31T23:36:28+02:00 (3 years ago)

Author:

Don-vip

Message:

see #21240 - upgrade HouseNumberTaggingTool plugin to JOSM 18173

Location:

applications/editors/josm/plugins/HouseNumberTaggingTool

Files:

• .settings/org.eclipse.core.resources.prefs (modified) (1 diff)
• build.xml (modified) (1 diff)
• src/org/openstreetmap/josm/plugins/housenumbertool/TagDialog.java (modified) (15 diffs)

applications/editors/josm/plugins/HouseNumberTaggingTool/.settings/org.eclipse.core.resources.prefs

@@ -1 +1 @@
 eclipse.preferences.version=1
+encoding/<project>=UTF-8
+encoding/src=UTF-8
 encoding/test=UTF-8
-encoding/src=UTF-8

applications/editors/josm/plugins/HouseNumberTaggingTool/build.xml

@@ -4 +4 @@
     <property name="commit.message" value="Initial version."/>
     <!-- enter the *lowest* JOSM version this plugin is currently compatible with -->
-    <property name="plugin.main.version" value="13007"/>
+    <property name="plugin.main.version" value="18173"/>
     <!-- Configure these properties (replace "..." accordingly).
          See https://josm.openstreetmap.de/wiki/DevelopersGuide/DevelopingPlugins

applications/editors/josm/plugins/HouseNumberTaggingTool/src/org/openstreetmap/josm/plugins/housenumbertool/TagDialog.java

@@ -1 +1 @@
 // License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.plugins.housenumbertool;
+
+import static org.openstreetmap.josm.tools.I18n.tr;
+import static org.openstreetmap.josm.tools.I18n.trn;
+
+import java.awt.Dimension;
+import java.awt.Font;
+import java.awt.GridBagConstraints;
+import java.awt.GridBagLayout;
+import java.awt.Insets;
+import java.awt.event.ActionEvent;
+import java.awt.event.ItemEvent;
+import java.awt.event.ItemListener;
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.FileOutputStream;
+import java.io.ObjectInputStream;
+import java.io.ObjectOutputStream;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.List;
+import java.util.Set;
+import java.util.TreeSet;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+
+import javax.swing.ButtonGroup;
+import javax.swing.JButton;
+import javax.swing.JCheckBox;
+import javax.swing.JComboBox;
+import javax.swing.JLabel;
+import javax.swing.JPanel;
+import javax.swing.JRadioButton;
+import javax.swing.JSlider;
+import javax.swing.JTextField;
+import javax.swing.SwingUtilities;
 
 import org.openstreetmap.josm.command.ChangePropertyCommand;
@@ -10 +46 @@
 import org.openstreetmap.josm.gui.ExtendedDialog;
 import org.openstreetmap.josm.gui.MainApplication;
-import org.openstreetmap.josm.gui.tagging.ac.AutoCompletingComboBox;
+import org.openstreetmap.josm.gui.tagging.ac.AutoCompComboBox;
 import org.openstreetmap.josm.gui.tagging.ac.AutoCompletionManager;
-
-import javax.swing.*;
-import java.awt.*;
-import java.awt.event.ActionEvent;
-import java.awt.event.ItemEvent;
-import java.awt.event.ItemListener;
-import java.io.*;
-import java.util.List;
-import java.util.*;
-import java.util.logging.Level;
-import java.util.logging.Logger;
-
-import static org.openstreetmap.josm.tools.I18n.tr;
-import static org.openstreetmap.josm.tools.I18n.trn;
 
 /**
@@ -47 +69 @@
 
     private static final String[] BUILDING_STRINGS = {
-        "yes", "apartments", "chapel", "church", "commercial", "dormitory", "hotel", "house", "residential", "terrace",  
-        "industrial", "retail", "warehouse", "cathedral",  "civic", "hospital", "school", "train_station", "transportation", 
-        "university", "public", "bridge", "bunker", "cabin", "construction", "farm_auxiliary", "garage", "garages", 
+        "yes", "apartments", "chapel", "church", "commercial", "dormitory", "hotel", "house", "residential", "terrace",
+        "industrial", "retail", "warehouse", "cathedral",  "civic", "hospital", "school", "train_station", "transportation",
+        "university", "public", "bridge", "bunker", "cabin", "construction", "farm_auxiliary", "garage", "garages",
         "greenhouse", "hangar", "hut", "roof", "shed", "stable"};
 
@@ -63 +85 @@
     private static final String TEMPLATE_DATA = "/template.data";
 
-    private AutoCompletingComboBox source;
-    private AutoCompletingComboBox country;
-    private AutoCompletingComboBox state;
-    private AutoCompletingComboBox suburb;
-    private AutoCompletingComboBox city;
-    private AutoCompletingComboBox postcode;
-    private AutoCompletingComboBox street;
+    private AutoCompComboBox<AutoCompletionItem> source;
+    private AutoCompComboBox<AutoCompletionItem> country;
+    private AutoCompComboBox<AutoCompletionItem> state;
+    private AutoCompComboBox<AutoCompletionItem> suburb;
+    private AutoCompComboBox<AutoCompletionItem> city;
+    private AutoCompComboBox<AutoCompletionItem> postcode;
+    private AutoCompComboBox<AutoCompletionItem> street;
     private JTextField housnumber;
     private JCheckBox buildingEnabled;
@@ -221 +243 @@
         editPanel.add(sourceEnabled, c);
 
-        source = new AutoCompletingComboBox();
-        source.setPossibleAcItems(acm.getTagValues(TAG_SOURCE));
+        source = new AutoCompComboBox<>();
+        source.getModel().addAllElements(acm.getTagValues(TAG_SOURCE));
         source.setPreferredSize(new Dimension(200, 24));
         source.setEditable(true);
@@ -271 +293 @@
         editPanel.add(countryEnabled, c);
 
-        country = new AutoCompletingComboBox();
-        country.setPossibleAcItems(acm.getTagValues(TAG_ADDR_COUNTRY));
+        country = new AutoCompComboBox<>();
+        country.getModel().addAllElements(acm.getTagValues(TAG_ADDR_COUNTRY));
         country.setPreferredSize(new Dimension(200, 24));
         country.setEditable(true);
@@ -321 +343 @@
         editPanel.add(stateEnabled, c);
 
-        state = new AutoCompletingComboBox();
-        state.setPossibleAcItems(acm.getTagValues(TAG_ADDR_STATE));
+        state = new AutoCompComboBox<>();
+        state.getModel().addAllElements(acm.getTagValues(TAG_ADDR_STATE));
         state.setPreferredSize(new Dimension(200, 24));
         state.setEditable(true);
@@ -371 +393 @@
         editPanel.add(suburbEnabled, c);
 
-        suburb = new AutoCompletingComboBox();
-        suburb.setPossibleAcItems(acm.getTagValues(TAG_ADDR_SUBURB));
+        suburb = new AutoCompComboBox<>();
+        suburb.getModel().addAllElements(acm.getTagValues(TAG_ADDR_SUBURB));
         suburb.setPreferredSize(new Dimension(200, 24));
         suburb.setEditable(true);
@@ -421 +443 @@
         editPanel.add(cityEnabled, c);
 
-        city = new AutoCompletingComboBox();
-        city.setPossibleAcItems(acm.getTagValues(TAG_ADDR_CITY));
+        city = new AutoCompComboBox<>();
+        city.getModel().addAllElements(acm.getTagValues(TAG_ADDR_CITY));
         city.setPreferredSize(new Dimension(200, 24));
         city.setEditable(true);
@@ -471 +493 @@
         editPanel.add(zipEnabled, c);
 
-        postcode = new AutoCompletingComboBox();
-        postcode.setPossibleAcItems(acm.getTagValues(TAG_ADDR_POSTCODE));
+        postcode = new AutoCompComboBox<>();
+        postcode.getModel().addAllElements(acm.getTagValues(TAG_ADDR_POSTCODE));
         postcode.setPreferredSize(new Dimension(200, 24));
         postcode.setEditable(true);
@@ -549 +571 @@
         g.add(placeRadio);
 
-        street = new AutoCompletingComboBox();
+        street = new AutoCompComboBox<>();
         if (dto.isTagStreet()) {
-            street.setPossibleItems(getPossibleStreets());
+            street.getModel().addAllElements(getPossibleStreets());
         } else {
-            street.setPossibleAcItems(acm.getTagValues(TAG_ADDR_PLACE));
+            street.getModel().addAllElements(acm.getTagValues(TAG_ADDR_PLACE));
         }
         street.setPreferredSize(new Dimension(200, 24));
@@ -756 +778 @@
     }
 
-    private String getAutoCompletingComboBoxValue(AutoCompletingComboBox box) {
+    private String getAutoCompletingComboBoxValue(AutoCompComboBox<AutoCompletionItem> box) {
         Object item = box.getSelectedItem();
         if (item != null) {
@@ -886 +908 @@
         if (!commands.isEmpty()) {
             SequenceCommand sequenceCommand = new SequenceCommand(
-                 trn("Updating properties of up to {0} object", 
+                 trn("Updating properties of up to {0} object",
                      "Updating properties of up to {0} objects", commands.size(), commands.size()), commands);
 
@@ -894 +916 @@
     }
 
-    private Collection<String> getPossibleStreets() {
-        /**
-         * Generates a list of all visible names of highways in order to do autocompletion on the road name.
-         */
-        Set<String> names = new TreeSet<>();
+    /**
+     * Generates a list of all visible names of highways in order to do autocompletion on the road name.
+     */
+    private Collection<AutoCompletionItem> getPossibleStreets() {
+        Set<AutoCompletionItem> names = new TreeSet<>();
         for (OsmPrimitive osm : MainApplication.getLayerManager().getEditDataSet().allNonDeletedPrimitives()) {
             if (osm.getKeys() != null && osm.keySet().contains("highway") && osm.keySet().contains("name")) {
-                names.add(osm.get("name"));
+                names.add(new AutoCompletionItem(osm.get("name")));
             }
         }
@@ -946 +968 @@
         public void itemStateChanged(ItemEvent e) {
             if (streetRadio.isSelected()) {
-                street.setPossibleItems(getPossibleStreets());
+                street.getModel().addAllElements(getPossibleStreets());
             } else {
-                street.setPossibleAcItems(acm.getTagValues(TAG_ADDR_PLACE));
+                street.getModel().addAllElements(acm.getTagValues(TAG_ADDR_PLACE));
             }
         }