Changeset 35674 in osm for applications

Timestamp:

2020-12-22T14:11:32+01:00 (4 years ago)

Author:

GerdP

Message:

• simplify updateEnabledState
• minor performance improvements
• checkstyle or sonarling issues, javadoc corrections

Location:

applications/editors/josm/plugins/utilsplugin2/src/org/openstreetmap/josm/plugins/utilsplugin2

Files:

• actions/AlignWayNodesAction.java (modified) (5 diffs)
• replacegeometry/ReplaceGeometryUtils.java (modified) (1 diff)
• selection/AdjacentWaysAction.java (modified) (1 diff)
• selection/ConnectedWaysAction.java (modified) (1 diff)
• selection/IntersectedWaysAction.java (modified) (1 diff)
• selection/IntersectedWaysRecursiveAction.java (modified) (1 diff)
• selection/MiddleNodesAction.java (modified) (1 diff)
• selection/SelectAllInsideAction.java (modified) (1 diff)
• selection/SelectHighwayAction.java (modified) (1 diff)
• selection/UnselectNodesAction.java (modified) (1 diff)

applications/editors/josm/plugins/utilsplugin2/src/org/openstreetmap/josm/plugins/utilsplugin2/actions/AlignWayNodesAction.java

@@ -11 +11 @@
 import java.util.List;
 import java.util.Set;
-import java.util.stream.Collectors;
 
 import javax.swing.JOptionPane;
@@ -27 +26 @@
 
 /**
- * Pastes relation membership from objects in the paste buffer onto selected object(s).
+ * Align way nodes. Similar to Align nodes in line, but uses a parent way as context.
  *
  * @author Zverik
@@ -139 +138 @@
     protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
         Set<Node> nodes = filterNodes(selection);
-        Set<Way> ways = findCommonWays(nodes);
-        setEnabled(ways != null && ways.size() == 1 && !nodes.isEmpty());
-    }
-
-    private Set<Way> findCommonWays(Set<Node> nodes) {
+        if (nodes.isEmpty())
+            setEnabled(false);
+        else {
+            Set<Way> ways = findCommonWays(nodes);
+            setEnabled(ways != null && ways.size() == 1);
+        }
+    }
+
+    private static Set<Way> findCommonWays(Set<Node> nodes) {
         Set<Way> ways = null;
-        for (Node n : nodes.stream().filter(n -> n.getDataSet() != null).collect(Collectors.toList())) {
+        for (Node n : nodes) {
+            if (n.getDataSet() == null)
+                continue;
             if (ways == null)
                 ways = new HashSet<>(n.getParentWays());
             else {
                 ways.retainAll(n.getParentWays());
+                if (ways.isEmpty())
+                    break;
             }
         }
@@ -155 +162 @@
     }
 
-    private Set<Node> filterNodes(Collection<? extends OsmPrimitive> selection) {
+    private static Set<Node> filterNodes(Collection<? extends OsmPrimitive> selection) {
         Set<Node> result = new HashSet<>();
         if (selection != null) {
@@ -174 +181 @@
      * @return the index of the node right after the largest empty span
      */
-    private int findFirstNode(Way way, Set<Node> nodes) {
+    private static int findFirstNode(Way way, Set<Node> nodes) {
         int pos = 0;
         while (pos < way.getNodesCount() && !nodes.contains(way.getNode(pos))) {

applications/editors/josm/plugins/utilsplugin2/src/org/openstreetmap/josm/plugins/utilsplugin2/replacegeometry/ReplaceGeometryUtils.java

@@ -169 +169 @@
             nodeToReplace = findNearestNode(subjectNode, nodePool.stream().filter(Node::isNew).collect(Collectors.toList()));
             if (nodeToReplace == null) {
-                nodeToReplace = findNearestNode(subjectNode, nodePool);
+                nodeToReplace = findNearestNode(subjectNode, nodePool);
             }
         }

applications/editors/josm/plugins/utilsplugin2/src/org/openstreetmap/josm/plugins/utilsplugin2/selection/AdjacentWaysAction.java

@@ -60 +60 @@
     @Override
     protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
-        if (selection == null) {
-            setEnabled(false);
-            return;
-        }
-        setEnabled(!selection.isEmpty());
+        setEnabled(selection != null && !selection.isEmpty());
     }
 }

applications/editors/josm/plugins/utilsplugin2/src/org/openstreetmap/josm/plugins/utilsplugin2/selection/ConnectedWaysAction.java

@@ -57 +57 @@
     @Override
     protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
-        if (selection == null) {
-            setEnabled(false);
-            return;
-        }
-        setEnabled(!selection.isEmpty());
+        setEnabled(selection != null && !selection.isEmpty());
     }
 }

applications/editors/josm/plugins/utilsplugin2/src/org/openstreetmap/josm/plugins/utilsplugin2/selection/IntersectedWaysAction.java

@@ -58 +58 @@
     @Override
     protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
-        if (selection == null) {
-            setEnabled(false);
-            return;
-        }
-        setEnabled(!selection.isEmpty());
+        setEnabled(selection != null && !selection.isEmpty());
     }
 }

applications/editors/josm/plugins/utilsplugin2/src/org/openstreetmap/josm/plugins/utilsplugin2/selection/IntersectedWaysRecursiveAction.java

@@ -58 +58 @@
     @Override
     protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
-        if (selection == null) {
-            setEnabled(false);
-            return;
-        }
-        setEnabled(!selection.isEmpty());
+        setEnabled(selection != null && !selection.isEmpty());
     }
 }

applications/editors/josm/plugins/utilsplugin2/src/org/openstreetmap/josm/plugins/utilsplugin2/selection/MiddleNodesAction.java

@@ -60 +60 @@
     @Override
     protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
-        if (selection == null) {
-            setEnabled(false);
-            return;
-        }
-        setEnabled(!selection.isEmpty());
+        setEnabled(selection != null && !selection.isEmpty());
     }
 }

applications/editors/josm/plugins/utilsplugin2/src/org/openstreetmap/josm/plugins/utilsplugin2/selection/SelectAllInsideAction.java

@@ -56 +56 @@
     @Override
     protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
-        if (selection == null) {
-            setEnabled(false);
-            return;
-        }
-        setEnabled(!selection.isEmpty());
+        setEnabled(selection != null && !selection.isEmpty());
     }
 }

applications/editors/josm/plugins/utilsplugin2/src/org/openstreetmap/josm/plugins/utilsplugin2/selection/SelectHighwayAction.java

@@ -119 +119 @@
     @Override
     protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
-        if (selection == null) {
-            setEnabled(false);
-            return;
-        }
-        int count = 0, rank = 100;
-        for (OsmPrimitive p : selection) {
-            if (p instanceof Way) {
-                count++;
-                rank = Math.min(rank, getHighwayRank(p));
+        int count = 0;
+        int rank = 100;
+        if (selection != null) {
+            for (OsmPrimitive p : selection) {
+                if (p instanceof Way) {
+                    count++;
+                    if (count > 2)
+                        break;
+                    rank = Math.min(rank, getHighwayRank(p));
+                }
             }
         }

applications/editors/josm/plugins/utilsplugin2/src/org/openstreetmap/josm/plugins/utilsplugin2/selection/UnselectNodesAction.java

@@ -41 +41 @@
     @Override
     protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
-        if (selection == null) {
-            setEnabled(false);
-            return;
-        }
-        setEnabled(!selection.isEmpty());
+        setEnabled(selection != null && !selection.isEmpty());
     }
 }