Changeset 35474 in osm for applications/editors/josm/plugins/buildings_tools/src/org

Timestamp:

2020-05-27T11:48:18+02:00 (5 years ago)

Author:

gerdp

Message:

see #josm19286: Actions should avoid to install listeners which are not needed

Location:

applications/editors/josm/plugins/buildings_tools/src/org/openstreetmap/josm/plugins/buildings_tools

Files:

• BuildingRectangleAction.java (modified) (1 diff)
• BuildingSizeAction.java (modified) (1 diff)
• MergeAddrPointsAction.java (modified) (3 diffs)

applications/editors/josm/plugins/buildings_tools/src/org/openstreetmap/josm/plugins/buildings_tools/BuildingRectangleAction.java

@@ -17 +17 @@
                         tr("Data: {0}", tr("Set buildings shape to rectangle")),
                         KeyEvent.VK_R, Shortcut.ALT),
-                true);
+                true, false);
     }
 

applications/editors/josm/plugins/buildings_tools/src/org/openstreetmap/josm/plugins/buildings_tools/BuildingSizeAction.java

@@ -16 +16 @@
                 Shortcut.registerShortcut("edit:buildingsdialog", tr("Edit: {0}", tr("Set buildings size")),
                 KeyEvent.VK_B, Shortcut.ALT_CTRL),
-                true, "edit:buildingsdialog", true);
+                true, "edit:buildingsdialog", false);
     }
 

applications/editors/josm/plugins/buildings_tools/src/org/openstreetmap/josm/plugins/buildings_tools/MergeAddrPointsAction.java

@@ -114 +114 @@
             int oldMulti = multi;
             for (Node n : addrNodes) {
-                if (Geometry.nodeInsidePolygon(n, w.getNodes()))
+                if (Geometry.nodeInsidePolygon(n, w.getNodes())) {
                     if (mergeNode != null) {
                         multi++;
@@ -120 +120 @@
                         // skipping
                         break;
-                    } else
+                    } else {
                         mergeNode = n;
+                    }
+                }
             }
             if (oldMulti != multi)
@@ -180 +182 @@
 
     @Override
+    protected boolean listenToSelectionChange() {
+        return false;
+    }
+
+    @Override
     protected void updateEnabledState() {
         setEnabled(getLayerManager().getEditDataSet() != null);