Changeset 35474 in osm for applications/editors

Timestamp:

2020-05-27T11:48:18+02:00 (4 years ago)

Author:

gerdp

Message:

see #josm19286: Actions should avoid to install listeners which are not needed

Location:

applications/editors/josm/plugins

Files:

• alignways/src/org/openstreetmap/josm/plugins/alignways/AlignWaysAction.java (modified) (1 diff)
• buildings_tools/src/org/openstreetmap/josm/plugins/buildings_tools/BuildingRectangleAction.java (modified) (1 diff)
• buildings_tools/src/org/openstreetmap/josm/plugins/buildings_tools/BuildingSizeAction.java (modified) (1 diff)
• buildings_tools/src/org/openstreetmap/josm/plugins/buildings_tools/MergeAddrPointsAction.java (modified) (3 diffs)
• reverter/src/reverter/RevertChangesetAction.java (modified) (1 diff)
• undelete/src/org/openstreetmap/josm/plugins/undelete/UndeleteAction.java (modified) (1 diff)

applications/editors/josm/plugins/alignways/src/org/openstreetmap/josm/plugins/alignways/AlignWaysAction.java

@@ -33 +33 @@
                 Shortcut.registerShortcut("tools:alignways", tr("Tool: {0}", tr("Align Ways")),
                                 KeyEvent.VK_SPACE, Shortcut.SHIFT),
-                true);
+                true, false);
         setEnabled(false);
     }

applications/editors/josm/plugins/buildings_tools/src/org/openstreetmap/josm/plugins/buildings_tools/BuildingRectangleAction.java

@@ -17 +17 @@
                         tr("Data: {0}", tr("Set buildings shape to rectangle")),
                         KeyEvent.VK_R, Shortcut.ALT),
-                true);
+                true, false);
     }
 

applications/editors/josm/plugins/buildings_tools/src/org/openstreetmap/josm/plugins/buildings_tools/BuildingSizeAction.java

@@ -16 +16 @@
                 Shortcut.registerShortcut("edit:buildingsdialog", tr("Edit: {0}", tr("Set buildings size")),
                 KeyEvent.VK_B, Shortcut.ALT_CTRL),
-                true, "edit:buildingsdialog", true);
+                true, "edit:buildingsdialog", false);
     }
 

applications/editors/josm/plugins/buildings_tools/src/org/openstreetmap/josm/plugins/buildings_tools/MergeAddrPointsAction.java

@@ -114 +114 @@
             int oldMulti = multi;
             for (Node n : addrNodes) {
-                if (Geometry.nodeInsidePolygon(n, w.getNodes()))
+                if (Geometry.nodeInsidePolygon(n, w.getNodes())) {
                     if (mergeNode != null) {
                         multi++;
@@ -120 +120 @@
                         // skipping
                         break;
-                    } else
+                    } else {
                         mergeNode = n;
+                    }
+                }
             }
             if (oldMulti != multi)
@@ -180 +182 @@
 
     @Override
+    protected boolean listenToSelectionChange() {
+        return false;
+    }
+
+    @Override
     protected void updateEnabledState() {
         setEnabled(getLayerManager().getEditDataSet() != null);

applications/editors/josm/plugins/reverter/src/reverter/RevertChangesetAction.java

@@ -19 +19 @@
         super(tr("Revert changeset"), "revert-changeset", tr("Revert changeset"),
             Shortcut.registerShortcut("tool:revert", tr("Tool: {0}", tr("Revert changeset")), KeyEvent.VK_T, Shortcut.CTRL_SHIFT),
-                true);
+                true, false);
     }
 

applications/editors/josm/plugins/undelete/src/org/openstreetmap/josm/plugins/undelete/UndeleteAction.java

@@ -236 +236 @@
      */
     public UndeleteAction() {
-        super(tr("Undelete object..."), "undelete", tr("Undelete object by id"),
-                Shortcut.registerShortcut("tools:undelete", tr("File: {0}", tr("Undelete object...")), KeyEvent.VK_U, Shortcut.ALT_SHIFT), true);
+                super(tr("Undelete object..."), "undelete", tr("Undelete object by id"),
+                                Shortcut.registerShortcut("tools:undelete", tr("File: {0}", tr("Undelete object...")), KeyEvent.VK_U,
+                                                Shortcut.ALT_SHIFT),
+                                true, false);
     }