Changeset 35262 in osm

Timestamp:

2019-12-28T15:13:36+01:00 (5 years ago)

Author:

donvip

Message:

fix #josm17563 - fix icon support, add unit test

Location:

applications/editors/josm/plugins/surveyor

Files:

• .classpath (modified) (1 diff)
• resources/surveyor.xml (modified) (3 diffs)
• src/org/openstreetmap/josm/plugins/surveyor/ButtonDescription.java (modified) (1 diff)
• src/org/openstreetmap/josm/plugins/surveyor/SurveyorComponent.java (modified) (1 diff)
• src/org/openstreetmap/josm/plugins/surveyor/SurveyorShowAction.java (modified) (4 diffs)
• src/org/openstreetmap/josm/plugins/surveyor/action/PlayAudioAction.java (modified) (3 diffs)
• src/org/openstreetmap/josm/plugins/surveyor/util/ResourceLoader.java (deleted)
• test (added)
• unit (added)
• unit/org (added)
• unit/org/openstreetmap (added)
• unit/org/openstreetmap/josm (added)
• unit/org/openstreetmap/josm/plugins (added)
• unit/org/openstreetmap/josm/plugins/surveyor (added)
• unit/org/openstreetmap/josm/plugins/surveyor/SurveyorShowActionTest.java (added)

applications/editors/josm/plugins/surveyor/.classpath

@@ -2 +2 @@
 <classpath>
         <classpathentry kind="src" path="src"/>
+        <classpathentry kind="src" output="bintest" path="unit">
+                <attributes>
+                        <attribute name="test" value="true"/>
+                </attributes>
+        </classpathentry>
+        <classpathentry including="resources/" kind="src" path=""/>
         <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.8"/>
         <classpathentry combineaccessrules="false" kind="src" path="/JOSM"/>
         <classpathentry combineaccessrules="false" kind="src" path="/JOSM-livegps"/>
+        <classpathentry kind="con" path="org.eclipse.jdt.junit.JUNIT_CONTAINER/4"/>
         <classpathentry kind="output" path="bin"/>
 </classpath>

applications/editors/josm/plugins/surveyor/resources/surveyor.xml

@@ -4 +4 @@
   <!-- action class: either fully qualified classnames or if not found,
        package at.dallermassl.josm.plugin.surveyor.action is assumed -->
-  <button label="Tunnel Start" hotkey="T" icon="styles/standard/vehicle/tunnel.png">
+  <button label="Tunnel Start" hotkey="T" icon="presets/transport/passage/tunnel.svg">
     <action class="PlayAudioAction" params="resource://audio/KDE_Window_Iconify.wav"/>
     <action class="SetWaypointAction" params="tunnel start"/>
@@ -14 +14 @@
     <action class="SetWaypointAction" params="bridge"/>
   </button>
-  <button label="Village/City" hotkey="V" icon="styles/standard/place.png">
+  <button label="Village/City" hotkey="V" icon="presets/place/village.svg">
     <action class="PlayAudioAction" params="resource://audio/KDE_Window_Iconify.wav"/>
     <action class="SetWaypointAction" params="village"/>
@@ -22 +22 @@
     -->
   </button>
-  <button label="Parking" hotkey="P" icon="styles/standard/vehicle/parking.png">
+  <button label="Parking" hotkey="P" icon="presets/vehicle/parking/parking.svg">
     <!--action class="SetNodeAction" params="amenity=parking"/-->
     <action class="PlayAudioAction" params="resource://audio/KDE_Window_Iconify.wav"/>
     <action class="SetWaypointAction" params="Parking"/>
   </button>
-  <button label="One Way" hotkey="O" icon="presets/oneway.png">
-    <action class="PlayAudioAction" params="resource://audio/KDE_Window_Iconify.wav"/>
-    <action class="SetWaypointAction" params="oneway=yes"/>
-  </button>
-  <button label="Church" hotkey="C" icon="styles/standard/religion/church.png">
+  <button label="Church" hotkey="C" icon="presets/religion/church.svg">
     <action class="PlayAudioAction" params="resource://audio/KDE_Window_Iconify.wav"/>
     <action class="SetNodeAction" params="amenity=place_of_worship,denomination=christian"/>
     <action class="SetWaypointAction" params="Church"/>
   </button>
-  <button label="Fuel Station" hotkey="F" icon="styles/standard/vehicle/fuel.png">
+  <button label="Fuel Station" hotkey="F" icon="presets/vehicle/fuel.svg">
     <!--action class="SetNodeAction" params="amenity=fuel"/-->
     <action class="PlayAudioAction" params="resource://audio/KDE_Window_Iconify.wav"/>
     <action class="SetWaypointAction" params="Fuel"/>
   </button>
-  <button label="Hotel" hotkey="H" icon="styles/standard/accommodation/hotel.png">
+  <button label="Hotel" hotkey="H" icon="presets/accommodation/hotel.svg">
     <action class="PlayAudioAction" params="resource://audio/KDE_Window_Iconify.wav"/>
     <action class="SetWaypointAction" params="Hotel"/>
   </button>
-  <button label="Restaurant" hotkey="R" icon="styles/standard/food/restaurant.png">
+  <button label="Restaurant" hotkey="R" icon="presets/food/restaurant.svg">
     <action class="PlayAudioAction" params="resource://audio/KDE_Window_Iconify.wav"/>
     <action class="SetNodeAction" params="amenity=restaurant"/>
     <action class="SetWaypointAction" params="Restaurant"/>
   </button>
-  <button label="Shopping" hotkey="S" icon="styles/standard/shop.png">
+  <button label="Shopping" hotkey="S" icon="presets/shop/mall.svg">
     <action class="PlayAudioAction" params="resource://audio/KDE_Window_Iconify.wav"/>
     <action class="SetWaypointAction" params="Info"/>
   </button>
-  <button label="WC" hotkey="W" icon="styles/standard/vehicle/parking/restarea_toilets.png">
+  <button label="WC" hotkey="W" icon="presets/service/toilets.svg">
     <action class="PlayAudioAction" params="resource://audio/KDE_Window_Iconify.wav"/>
     <action class="SetWaypointAction" params="Info"/>
   </button>
-  <button label="Camping" hotkey="Z" icon="styles/standard/accommodation/camping/caravan.png">
+  <button label="Camping" hotkey="Z" icon="presets/accommodation/caravan.svg">
     <action class="PlayAudioAction" params="resource://audio/KDE_Window_Iconify.wav"/>
     <action class="SetWaypointAction" params="Camping"/>

applications/editors/josm/plugins/surveyor/src/org/openstreetmap/josm/plugins/surveyor/ButtonDescription.java

@@ -175 +175 @@
         String actionName = tr(getLabel()) + " (" + hotkey + ")";
 
-        Icon icon = ImageProvider.getIfAvailable(iconName);
-        if (icon == null)
-            icon = ImageProvider.getIfAvailable("markers", iconName);
-        if (icon == null)
-            icon = ImageProvider.getIfAvailable("symbols", iconName);
-        if (icon == null)
-            icon = ImageProvider.getIfAvailable("nodes", iconName);
+        Icon icon = null;
+        if (iconName != null) {
+            icon = ImageProvider.getIfAvailable(iconName);
+            if (icon == null)
+                icon = ImageProvider.getIfAvailable("markers", iconName);
+            if (icon == null)
+                icon = ImageProvider.getIfAvailable("symbols", iconName);
+            if (icon == null)
+                icon = ImageProvider.getIfAvailable("nodes", iconName);
+        }
 
         MetaAction action = new MetaAction(actionName, icon);

applications/editors/josm/plugins/surveyor/src/org/openstreetmap/josm/plugins/surveyor/SurveyorComponent.java

@@ -64 +64 @@
      */
     public void setColumns(String columnsString) {
-        System.out.println("setting columns to " +columnsString);
         columns = Integer.parseInt(columnsString);
         buttonPanel.setLayout(new GridLayout(rows, columns));

applications/editors/josm/plugins/surveyor/src/org/openstreetmap/josm/plugins/surveyor/SurveyorShowAction.java

@@ -23 +23 @@
 import org.openstreetmap.josm.actions.JosmAction;
 import org.openstreetmap.josm.gui.MainApplication;
-import org.openstreetmap.josm.plugins.surveyor.util.ResourceLoader;
+import org.openstreetmap.josm.io.CachedFile;
 import org.openstreetmap.josm.spi.preferences.Config;
 import org.openstreetmap.josm.tools.Logging;
@@ -107 +107 @@
     }
 
-    public SurveyorComponent createComponent() {
+    public static SurveyorComponent createComponent() {
         String source = Config.getPref().get("surveyor.source");
-        if (source == null || source.length() == 0) {
+        if (source == null || source.isEmpty()) {
             source = DEFAULT_SOURCE;
             Config.getPref().put("surveyor.source", DEFAULT_SOURCE);
-            // <FIXXME date="04.05.2007" author="cdaller">
-            // TODO copy xml file to .josm directory if it does not exist!
-            // </FIXXME>
         }
-        try (InputStream in = ResourceLoader.getInputStream(source)) {
+        try (CachedFile cf = new CachedFile(source); InputStream in = cf.getInputStream()) {
             return createComponent(in);
         } catch (IOException e) {
@@ -134 +131 @@
      * @throws SAXException if the xml could not be read.
      */
-    public SurveyorComponent createComponent(InputStream in) throws SAXException {
+    public static SurveyorComponent createComponent(InputStream in) throws SAXException {
         XmlObjectParser parser = new XmlObjectParser();
         parser.mapOnStart("surveyor", SurveyorComponent.class);
@@ -146 +143 @@
             Object object = parser.next();
             if (object instanceof SurveyorComponent) {
-                //System.out.println("SurveyorComponent " + object);
                 surveyorComponent = (SurveyorComponent) object;
             } else if (object instanceof ButtonDescription) {
-                //System.out.println("ButtonDescription " + object);
                 ((ButtonDescription) object).setActions(actions);
                 surveyorComponent.addButton(((ButtonDescription) object));
                 actions = new ArrayList<>();
             } else if (object instanceof SurveyorActionDescription) {
-                //System.out.println("SurveyorActionDescription " + object);
                 actions.add((SurveyorActionDescription) object);
             } else {

applications/editors/josm/plugins/surveyor/src/org/openstreetmap/josm/plugins/surveyor/action/PlayAudioAction.java

@@ -4 +4 @@
 import java.io.BufferedInputStream;
 import java.io.IOException;
-import java.io.InputStream;
 
 import javax.sound.sampled.AudioFormat;
@@ -15 +14 @@
 
 import org.openstreetmap.josm.gui.MainApplication;
+import org.openstreetmap.josm.io.CachedFile;
 import org.openstreetmap.josm.plugins.surveyor.GpsActionEvent;
-import org.openstreetmap.josm.plugins.surveyor.util.ResourceLoader;
 import org.openstreetmap.josm.tools.Logging;
 
@@ -32 +31 @@
         // run as a separate thread
         MainApplication.worker.execute(() -> {
-            try {
-                if (audioSource == null) {
-                    audioSource = getParameters().get(0);
-                }
-                InputStream in = new BufferedInputStream(ResourceLoader.getInputStream(audioSource));
-                AudioInputStream stream = AudioSystem.getAudioInputStream(in);
+            if (audioSource == null) {
+                audioSource = getParameters().get(0);
+            }
+            try (CachedFile cf = new CachedFile(audioSource)) {
+                AudioInputStream stream = AudioSystem.getAudioInputStream(new BufferedInputStream(cf.getInputStream()));
 
                 // At present, ALAW and ULAW encodings must be converted