Changeset 35147 in osm for applications

Timestamp:

2019-09-27T14:57:22+02:00 (5 years ago)

Author:

donvip

Message:

code cleanup, javadoc

Location:

applications/editors/josm/plugins/tag2link/src/org/openstreetmap/josm/plugins/tag2link

Files:

• Tag2LinkRuleChecker.java (modified) (3 diffs)
• data/Link.java (modified) (1 diff)
• data/LinkPost.java (modified) (1 diff)

applications/editors/josm/plugins/tag2link/src/org/openstreetmap/josm/plugins/tag2link/Tag2LinkRuleChecker.java

@@ -20 +20 @@
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.Iterator;
 import java.util.Locale;
 import java.util.Map;
+import java.util.Map.Entry;
 import java.util.function.BiFunction;
 import java.util.regex.Matcher;
@@ -134 +134 @@
         return result;
     }
-    
+
     private static void replaceMapParams(Map<String, String> map, EvalResult eval) {
-        for (Iterator<String> it = map.keySet().iterator(); it.hasNext(); ) {
-            String key = it.next();
-            String value = map.get(key);
+        for (Entry<String, String> e : map.entrySet()) {
+            String key = e.getKey();
+            String value = e.getValue();
             String key2 = replaceParams(key, eval);
             String value2 = replaceParams(value, eval);
@@ -153 +153 @@
         }
     }
-    
+
     private static Collection<Link> processEval(EvalResult eval, Rule rule, Source source) {
         Collection<Link> result = new ArrayList<>();

applications/editors/josm/plugins/tag2link/src/org/openstreetmap/josm/plugins/tag2link/data/Link.java

@@ -16 +16 @@
 package org.openstreetmap.josm.plugins.tag2link.data;
 
+/**
+ * A link that should be opened using a GET HTTP request.
+ */
 public class Link implements Cloneable {
     public String name;

applications/editors/josm/plugins/tag2link/src/org/openstreetmap/josm/plugins/tag2link/data/LinkPost.java

@@ -19 +19 @@
 import java.util.Map;
 
+/**
+ * A link that should be opened using a POST HTTP request.
+ */
 public class LinkPost extends Link {