Changeset 34965 in osm for applications/editors/josm/plugins

Timestamp:

2019-04-07T07:11:41+02:00 (5 years ago)

Author:

gerdp

Message:

fix SonarLint/javadoc issues

Location:

applications/editors/josm/plugins/poly/src/poly

Files:

• DownloadPolyTask.java (modified) (2 diffs)
• PolyImporter.java (modified) (3 diffs)

applications/editors/josm/plugins/poly/src/poly/DownloadPolyTask.java

@@ -43 +43 @@
     }
 
+    /**
+     * Class to download and parse a poly file.  
+     */
     public static class ServerPolyReader extends OsmServerReader {
         private String url;
 
+        /**
+         * Create new {@link ServerPolyReader}
+         * @param url
+         */
         public ServerPolyReader(String url) {
             this.url = url;
@@ -53 +60 @@
         public DataSet parseOsm(ProgressMonitor progressMonitor) throws OsmTransferException {
             try {
-                progressMonitor.beginTask(tr("Contacting Server...", 10));
+                progressMonitor.beginTask(tr("Contacting Server..."));
                 return new PolyImporter().parseDataSet(url);
             } catch (Exception e) {

applications/editors/josm/plugins/poly/src/poly/PolyImporter.java

@@ -93 +93 @@
                 parsingSection = false;
                 name = null;
-            } else if (line.equals("END")) {
+            } else if ("END".equals(line)) {
                 if (!parsingSection) {
                     area = null;
@@ -238 +238 @@
         }
 
+        /**
+         * Store a coordinate
+         * @param node the coordinate
+         */
         public void addNode(LatLon node) {
             if (nodes.isEmpty() || !(nodes.get(nodes.size()-1).equals(node) || nodes.get(0).equals(node)))
@@ -255 +259 @@
         }
 
+        /**
+         * Convert a ring to an OSM way
+         * @param ds the dataset in which the way is stored
+         * @param isMultipolygon true means the way is part of a multipolygon relation
+         */
         public void constructWay(DataSet ds, boolean isMultipolygon) {
             way = new Way();