Changeset 34793 in osm for applications/editors/josm/plugins

Timestamp:

2018-12-28T17:40:37+01:00 (6 years ago)

Author:

gerdp

Message:

see #17040: use ArrayList instead of HashSet and create a new instance instead of using clear().

File:

• applications/editors/josm/plugins/utilsplugin2/src/org/openstreetmap/josm/plugins/utilsplugin2/actions/TagBufferAction.java (modified) (5 diffs)

applications/editors/josm/plugins/utilsplugin2/src/org/openstreetmap/josm/plugins/utilsplugin2/actions/TagBufferAction.java

@@ -8 +8 @@
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.HashSet;
 import java.util.List;
-import java.util.Set;
 
 import org.openstreetmap.josm.actions.JosmAction;
@@ -31 +29 @@
     private static final String TITLE = tr("Copy tags from previous selection");
     private static final TagCollection EmptyTags = new TagCollection();
-    private final Set<OsmPrimitive> selectionBuf = new HashSet<>();
+    private List<OsmPrimitive> selectionBuf = new ArrayList<>();
     private TagCollection tagsToPaste = EmptyTags;
     /**
@@ -72 +70 @@
         if (getLayerManager().getEditDataSet() == null) {
             setEnabled(false);
-            selectionBuf.clear();
+            selectionBuf = new ArrayList<>();
             tagsToPaste = EmptyTags;
         } else
@@ -84 +82 @@
                 tagsToPaste = new TagCollection(oldTags);
         }
-        selectionBuf.clear();
-        selectionBuf.addAll(selection);
-
+        selectionBuf = new ArrayList<>(selection);
         setEnabled(!selection.isEmpty() && !tagsToPaste.isEmpty());
     }
@@ -94 +90 @@
      * @param selection the selection
      */
-    private static TagCollection getCommonTags(Set<OsmPrimitive> selection) {
+    private static TagCollection getCommonTags(List<OsmPrimitive> selection) {
         if (selection.isEmpty())
             return EmptyTags;