Changeset 34792 in osm for applications/editors/josm/plugins/utilsplugin2/src

Timestamp:

2018-12-28T17:40:08+01:00 (6 years ago)

Author:

gerdp

Message:

fix #16382 Add Source Tag doesn't work

Similar solution as with #14862.

File:

• applications/editors/josm/plugins/utilsplugin2/src/org/openstreetmap/josm/plugins/utilsplugin2/actions/TagSourceAction.java (modified) (3 diffs)

applications/editors/josm/plugins/utilsplugin2/src/org/openstreetmap/josm/plugins/utilsplugin2/actions/TagSourceAction.java

@@ -6 +6 @@
 import java.awt.event.ActionEvent;
 import java.awt.event.KeyEvent;
+import java.util.ArrayList;
 import java.util.Collection;
-import java.util.HashSet;
-import java.util.Set;
+import java.util.List;
 
 import org.openstreetmap.josm.actions.JosmAction;
@@ -25 +25 @@
     private static final String TITLE = tr("Add Source Tag");
     private String source;
-    private Set<OsmPrimitive> selectionBuf = new HashSet<>();
-    private boolean clickedTwice = false;
+    private List<OsmPrimitive> selectionBuf = new ArrayList<>();
 
     public TagSourceAction() {
@@ -45 +44 @@
         UndoRedoHandler.getInstance().add(new ChangePropertyCommand(selection, "source", source));
     }
-
     @Override
     protected void updateEnabledState() {
         if (getLayerManager().getEditDataSet() == null) {
             setEnabled(false);
-            if (selectionBuf != null)
-                selectionBuf.clear();
+            selectionBuf = new ArrayList<>();
         } else
             updateEnabledState(getLayerManager().getEditDataSet().getSelected());
     }
 
+
     @Override
     protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
-        if (selection == null || selection.isEmpty()) {
-            selectionBuf.clear();
-            clickedTwice = false;
-            setEnabled(false);
-            return;
+        if (!selectionBuf.isEmpty()) {
+                String newSource = null;
+                for (OsmPrimitive p : selectionBuf) {
+                        String s = p.get("source");
+                        if (s != null) {
+                                if (newSource == null)
+                                        newSource = s;
+                                else {
+                                        if (!newSource.equals(s)) {
+                                                newSource = null;
+                                                break;
+                                        }
+                                }
+                        }
+                }
+                if (newSource != null && !newSource.isEmpty()) {
+                source = newSource;
+                Config.getPref().put("sourcetag.value", source);
+                }
         }
-
-        if (selectionBuf.size() == selection.size() && selectionBuf.containsAll(selection)) {
-            if (!clickedTwice)
-                clickedTwice = true;
-            else {
-                // tags may have been changed, get the source
-                String newSource = null;
-                for (OsmPrimitive p : selection) {
-                    String value = p.get("source");
-                    if (value != null && newSource == null)
-                        newSource = value;
-                    else if (value != null ? !value.equals(newSource) : newSource != null) {
-                        newSource = "";
-                        break;
-                    }
-                }
-                if (newSource != null && newSource.length() > 0 && !newSource.equals(source)) {
-                    source = newSource;
-                    Config.getPref().put("sourcetag.value", source);
-                }
-            }
-        } else
-            clickedTwice = false;
-        selectionBuf.clear();
-        selectionBuf.addAll(selection);
-        setEnabled(source != null && source.length() > 0);
+        selectionBuf = new ArrayList<>(selection);
+        setEnabled(!selection.isEmpty() && source != null && !source.isEmpty());
     }
 }