Changeset 34683 in osm for applications

Timestamp:

2018-10-20T15:49:44+02:00 (6 years ago)

Author:

holgermappt

Message:

Fix linter errors: Whitespaces, make methods that do not access class variables static.

Location:

applications/editors/josm/plugins/photoadjust/src/org/openstreetmap/josm/plugins/photoadjust

Files:

• PhotoAdjustPlugin.java (modified) (3 diffs)
• PhotoPropertyEditor.java (modified) (2 diffs)
• UntaggedGeoImageLayerAction.java (modified) (3 diffs)

applications/editors/josm/plugins/photoadjust/src/org/openstreetmap/josm/plugins/photoadjust/PhotoAdjustPlugin.java

@@ -23 +23 @@
  */
 public class PhotoAdjustPlugin extends Plugin implements ActiveLayerChangeListener {
-  
+
     private GeoImageLayer imageLayer;
     private MouseAdapter mouseAdapter;
@@ -32 +32 @@
      * Will be invoked by JOSM to bootstrap the plugin.
      *
-     * @param info  information about the plugin and its local installation    
+     * @param info  information about the plugin and its local installation
      */
     public PhotoAdjustPlugin(PluginInformation info) {
-        super(info);
+        super(info);
         GeoImageLayer.registerMenuAddition(new UntaggedGeoImageLayerAction());
         PhotoPropertyEditor.init();
@@ -72 +72 @@
 
     /**
-     * Called when the JOSM map frame is created or destroyed. 
+     * Called when the JOSM map frame is created or destroyed.
      */
     @Override

applications/editors/josm/plugins/photoadjust/src/org/openstreetmap/josm/plugins/photoadjust/PhotoPropertyEditor.java

@@ -41 +41 @@
  */
 public class PhotoPropertyEditor {
+
+    /**
+     * This class is not intended to be instantiated.  Throw an exception if
+     * it is.
+     */
+    private PhotoPropertyEditor() {
+        throw new IllegalStateException("Utility class");
+    }
 
     /**
@@ -365 +373 @@
          * @return {@code true} if the values differ, {@code false} otherwise.
          */
-        private boolean isDoubleFieldDifferent(JosmTextField txtFld,
-                                               Double value) {
+        private static boolean isDoubleFieldDifferent(JosmTextField txtFld,
+                                                      Double value) {
             final Double fieldValue = getDoubleValue(txtFld);
             if (fieldValue == null) {

applications/editors/josm/plugins/photoadjust/src/org/openstreetmap/josm/plugins/photoadjust/UntaggedGeoImageLayerAction.java

@@ -35 +35 @@
      * @return the layer this menu entry belongs to
      */
-    private GeoImageLayer getSelectedLayer() {
+    private static GeoImageLayer getSelectedLayer() {
         return (GeoImageLayer)LayerListDialog.getInstance().getModel()
             .getSelectedLayers().get(0);
@@ -42 +42 @@
     /** This is called after the menu entry was selected. */
     @Override
-    public void actionPerformed(ActionEvent arg0) {
+    public void actionPerformed(ActionEvent evt) {
         GeoImageLayer layer = getSelectedLayer();
         if (layer != null) {
@@ -69 +69 @@
      * @return {@code true} if there is any image without coordinates
      */
-    private boolean enabled(GeoImageLayer layer) {
+    private static boolean enabled(GeoImageLayer layer) {
         if (layer != null) {
             for (ImageEntry img: layer.getImages()) {