Changeset 34675 in osm for applications/editors

Timestamp:

2018-09-24T19:53:07+02:00 (6 years ago)

Author:

donvip

Message:

fix EDT violation, use scaled icons

File:

• applications/editors/josm/plugins/opendata/src/org/openstreetmap/josm/plugins/opendata/core/gui/ModulePreference.java (modified) (9 diffs)

applications/editors/josm/plugins/opendata/src/org/openstreetmap/josm/plugins/opendata/core/gui/ModulePreference.java

@@ -58 +58 @@
 
 public class ModulePreference implements SubPreferenceSetting {
-    /*public static class Factory implements PreferenceSettingFactory {
-        public PreferenceSetting createPreferenceSetting() {
-            return new ModulePreference();
-        }
-    }*/
 
     public static String buildDownloadSummary(ModuleDownloadTask task) {
@@ -179 +174 @@
                 new ButtonSpec(
                         tr("OK"),
-                        ImageProvider.get("ok"),
+                        new ImageProvider("ok"),
                         tr("Accept the new module sites and close the dialog"),
                         null /* no special help topic */
@@ -185 +180 @@
                 new ButtonSpec(
                         tr("Cancel"),
-                        ImageProvider.get("cancel"),
+                        new ImageProvider("cancel"),
                         tr("Close the dialog"),
                         null /* no special help topic */
@@ -258 +253 @@
             putValue(NAME, tr("Download list"));
             putValue(SHORT_DESCRIPTION, tr("Download the list of available modules"));
-            putValue(SMALL_ICON, ImageProvider.get("download"));
+            new ImageProvider("download").getResource().attachImageIcon(this);
         }
 
@@ -284 +279 @@
             putValue(NAME, tr("Update modules"));
             putValue(SHORT_DESCRIPTION, tr("Update the selected modules"));
-            putValue(SMALL_ICON, ImageProvider.get("dialogs", "refresh"));
+            new ImageProvider("dialogs", "refresh").getResource().attachImageIcon(this);
         }
 
@@ -297 +292 @@
             }
             sb.append("</html>");
-            HelpAwareOptionPane.showOptionDialog(
+            GuiHelper.runInEDTAndWait(() -> HelpAwareOptionPane.showOptionDialog(
                     pnlModulePreferences,
                     sb.toString(),
@@ -303 +298 @@
                     !failed.isEmpty() ? JOptionPane.WARNING_MESSAGE : JOptionPane.INFORMATION_MESSAGE,
                             HelpUtil.ht("/Preferences/Modules")
-                    );
+                    ));
         }
 
@@ -337 +332 @@
                 model.refreshLocalModuleVersion(moduleDownloadTask.getDownloadedModules());
                 model.clearPendingModules(moduleDownloadTask.getDownloadedModules());
-                GuiHelper.runInEDT(new Runnable() {
-                    @Override
-                    public void run() {
-                        pnlModulePreferences.refreshView();
-                    }
-                });
+                GuiHelper.runInEDT(() -> pnlModulePreferences.refreshView());
             };
 
@@ -382 +372 @@
             putValue(NAME, tr("Configure sites..."));
             putValue(SHORT_DESCRIPTION, tr("Configure the list of sites where modules are downloaded from"));
-            putValue(SMALL_ICON, ImageProvider.get("dialogs", "settings"));
+            new ImageProvider("dialogs", "settings").getResource().attachImageIcon(this);
         }