Changeset 34660 in osm for applications/editors

Timestamp:

2018-09-15T14:44:00+02:00 (6 years ago)

Author:

donvip

Message:

fix UnnecessaryParentheses warnings

Location:

applications/editors/josm/plugins/pdfimport

Files:

• .settings/org.eclipse.jdt.core.prefs (modified) (5 diffs)
• src/org/openstreetmap/josm/plugins/pdfimport/FilePlacement18.java (modified) (3 diffs)
• src/org/openstreetmap/josm/plugins/pdfimport/LayerInfo.java (modified) (1 diff)
• src/org/openstreetmap/josm/plugins/pdfimport/LoadPdfDialog.java (modified) (2 diffs)

applications/editors/josm/plugins/pdfimport/.settings/org.eclipse.jdt.core.prefs

@@ -7 +7 @@
 org.eclipse.jdt.core.compiler.annotation.nullanalysis=disabled
 org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
+org.eclipse.jdt.core.compiler.codegen.methodParameters=do not generate
 org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.8
 org.eclipse.jdt.core.compiler.codegen.unusedLocal=preserve
@@ -13 +14 @@
 org.eclipse.jdt.core.compiler.debug.localVariable=generate
 org.eclipse.jdt.core.compiler.debug.sourceFile=generate
+org.eclipse.jdt.core.compiler.doc.comment.support=enabled
 org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning
 org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
@@ -36 +38 @@
 org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=warning
 org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=ignore
+org.eclipse.jdt.core.compiler.problem.invalidJavadoc=warning
+org.eclipse.jdt.core.compiler.problem.invalidJavadocTags=enabled
+org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsDeprecatedRef=enabled
+org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsNotVisibleRef=enabled
+org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsVisibility=private
 org.eclipse.jdt.core.compiler.problem.localVariableHiding=ignore
 org.eclipse.jdt.core.compiler.problem.methodWithConstructorName=warning
@@ -42 +49 @@
 org.eclipse.jdt.core.compiler.problem.missingEnumCaseDespiteDefault=disabled
 org.eclipse.jdt.core.compiler.problem.missingHashCodeMethod=ignore
+org.eclipse.jdt.core.compiler.problem.missingJavadocComments=ignore
+org.eclipse.jdt.core.compiler.problem.missingJavadocCommentsOverriding=disabled
+org.eclipse.jdt.core.compiler.problem.missingJavadocCommentsVisibility=public
+org.eclipse.jdt.core.compiler.problem.missingJavadocTagDescription=all_standard_tags
+org.eclipse.jdt.core.compiler.problem.missingJavadocTags=warning
+org.eclipse.jdt.core.compiler.problem.missingJavadocTagsMethodTypeParameters=disabled
+org.eclipse.jdt.core.compiler.problem.missingJavadocTagsOverriding=disabled
+org.eclipse.jdt.core.compiler.problem.missingJavadocTagsVisibility=private
 org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore
 org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotationForInterfaceMethodImplementation=enabled
@@ -97 +112 @@
 org.eclipse.jdt.core.compiler.problem.unusedWarningToken=warning
 org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=warning
+org.eclipse.jdt.core.compiler.release=disabled
 org.eclipse.jdt.core.compiler.source=1.8

applications/editors/josm/plugins/pdfimport/src/org/openstreetmap/josm/plugins/pdfimport/FilePlacement18.java

@@ -324 +324 @@
                             maxEastField.getValue(), maxNorthField.getValue());
                 } catch (Exception e) {
-                    Hint=(tr("Check numbers"));
+                    Hint = tr("Check numbers");
                     return;
                 }
                 String transformError = placement.prepareTransform();
                 if (transformError != null) {
-                    Hint=(transformError);
+                    Hint = transformError;
                     return;
                 }
@@ -335 +335 @@
             } finally {
                 hintField.setText(Hint);
-                if (dependsOnValid!=null) dependsOnValid.setEnabled(fc.valid && panel.isEnabled());
+                if (dependsOnValid != null)
+                    dependsOnValid.setEnabled(fc.valid && panel.isEnabled());
             }
 
@@ -342 +343 @@
 
         public void setDependsOnValid(JComponent c) {
-            dependsOnValid=c;
+            dependsOnValid = c;
         }
 

applications/editors/josm/plugins/pdfimport/src/org/openstreetmap/josm/plugins/pdfimport/LayerInfo.java

@@ -31 +31 @@
     @Override
     public boolean equals(Object o) {
+        if (!(o instanceof LayerInfo)) {
+            return false;
+        }
         LayerInfo l = (LayerInfo) o;
         boolean eq = this.width == l.width &&
         this.divider == l.divider &&
         this.dash == l.dash;
-
 
         if (this.fill != null) {

applications/editors/josm/plugins/pdfimport/src/org/openstreetmap/josm/plugins/pdfimport/LoadPdfDialog.java

@@ -145 +145 @@
 
             removeSmallObjectsSize = new GuiFieldDouble(Preferences.getRemoveSmallValue());
-            removeSmallObjectsCheck = new GuiFieldBool(tr("Remove objects smaller than"),Preferences.isRemoveSmall());
+            removeSmallObjectsCheck = new GuiFieldBool(tr("Remove objects smaller than"), Preferences.isRemoveSmall());
             removeSmallObjectsCheck.setCompanion(removeSmallObjectsSize);
 
-            removeLargeObjectsSize = new GuiFieldDouble((Preferences.getRemoveLargeValue()));
-            removeLargeObjectsCheck = new GuiFieldBool(tr("Remove objects larger than"),Preferences.isRemoveLarge());
+            removeLargeObjectsSize = new GuiFieldDouble(Preferences.getRemoveLargeValue());
+            removeLargeObjectsCheck = new GuiFieldBool(tr("Remove objects larger than"), Preferences.isRemoveLarge());
             removeLargeObjectsCheck.setCompanion(removeLargeObjectsSize);
 
@@ -156 +156 @@
             colorFilterCheck.setCompanion(colorFilterColor);
 
-            removeParallelSegmentsTolerance = new GuiFieldDouble((Preferences.getRemoveParallelValue()));
-            removeParallelSegmentsCheck = new GuiFieldBool(tr("Remove parallel lines"),Preferences.isRemoveParallel());
+            removeParallelSegmentsTolerance = new GuiFieldDouble(Preferences.getRemoveParallelValue());
+            removeParallelSegmentsCheck = new GuiFieldBool(tr("Remove parallel lines"), Preferences.isRemoveParallel());
             removeParallelSegmentsCheck.setCompanion(removeParallelSegmentsTolerance);
 
-            limitPathCount = new GuiFieldInteger((Preferences.getLimitPathValue()));
-            limitPathCountCheck = new GuiFieldBool(tr("Take only first X paths"),Preferences.isLimitPath());
+            limitPathCount = new GuiFieldInteger(Preferences.getLimitPathValue());
+            limitPathCountCheck = new GuiFieldBool(tr("Take only first X paths"), Preferences.isLimitPath());
             limitPathCountCheck.setCompanion(limitPathCount);
 
-            splitOnColorChangeCheck = new GuiFieldBool(tr("Color/width change"),Preferences.isLayerAttribChange());
+            splitOnColorChangeCheck = new GuiFieldBool(tr("Color/width change"), Preferences.isLayerAttribChange());
             splitOnShapeClosedCheck = new GuiFieldBool(tr("Shape closed"), Preferences.isLayerClosed());