Changeset 33692 in osm for applications/editors/josm/plugins

Timestamp:

2017-10-03T22:17:31+02:00 (7 years ago)

Author:

donvip

Message:

fix #josm15389

Location:

applications/editors/josm/plugins/addrinterpolation

Files:

• build.xml (modified) (1 diff)
• src/org/openstreetmap/josm/plugins/AddrInterpolation/AddrInterpolationAction.java (modified) (1 diff)
• src/org/openstreetmap/josm/plugins/AddrInterpolation/AddrInterpolationDialog.java (modified) (15 diffs)
• src/org/openstreetmap/josm/plugins/AddrInterpolation/AddrInterpolationPlugin.java (modified) (3 diffs)
• src/org/openstreetmap/josm/plugins/AddrInterpolation/EscapeDialog.java (modified) (1 diff)

applications/editors/josm/plugins/addrinterpolation/build.xml

@@ -4 +4 @@
     <property name="commit.message" value="Impoved Icon"/>
     <!-- enter the *lowest* JOSM version this plugin is currently compatible with -->
-    <property name="plugin.main.version" value="10580"/>
+    <property name="plugin.main.version" value="12726"/>
     
     <!-- Configure these properties (replace "..." accordingly).

applications/editors/josm/plugins/addrinterpolation/src/org/openstreetmap/josm/plugins/AddrInterpolation/AddrInterpolationAction.java

@@ -27 +27 @@
     }
 
+    @Override
     public void actionPerformed(ActionEvent e) {
         /*AddrInterpolationDialog addrDialog =*/ new AddrInterpolationDialog(tr("Define Address Interpolation"));
     }
 
+    @Override
     public void selectionChanged(
             Collection<? extends OsmPrimitive> newSelection) {

applications/editors/josm/plugins/addrinterpolation/src/org/openstreetmap/josm/plugins/AddrInterpolation/AddrInterpolationDialog.java

@@ -24 +24 @@
 import java.util.ArrayList;
 import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
 import java.util.LinkedList;
+import java.util.Map;
 import java.util.regex.Pattern;
 
@@ -54 +57 @@
 import org.openstreetmap.josm.data.osm.RelationMember;
 import org.openstreetmap.josm.data.osm.Way;
+import org.openstreetmap.josm.gui.MainApplication;
 import org.openstreetmap.josm.gui.widgets.UrlLabel;
 import org.openstreetmap.josm.tools.ImageProvider;
@@ -266 +270 @@
         // Numeric increment box can be enabled or disabled.
         addrInterpolationList.addActionListener(new ActionListener() {
+            @Override
             public void actionPerformed(ActionEvent e) {
                 int selectedIndex = addrInterpolationList.getSelectedIndex();
@@ -527 +532 @@
     private String FindRelation() {
         String relationDescription = null;
-        DataSet currentDataSet = Main.getLayerManager().getEditDataSet();
+        DataSet currentDataSet = MainApplication.getLayerManager().getEditDataSet();
         if (currentDataSet != null) {
             for (Relation relation : currentDataSet.getRelations()) {
@@ -574 +579 @@
         int namedWayCount = 0;
         int unNamedWayCount = 0;
-        DataSet currentDataSet = Main.getLayerManager().getEditDataSet();
+        DataSet currentDataSet = MainApplication.getLayerManager().getEditDataSet();
         if (currentDataSet != null) {
             for (OsmPrimitive osm : currentDataSet.getSelectedWays()) {
@@ -667 +672 @@
     }
 
+    @Override
     public void actionPerformed(ActionEvent e) {
         if ("ok".equals(e.getActionCommand())) {
@@ -761 +767 @@
                 newHouseNumberNode.put("addr:housenumber", newHouseNumber);
 
-                commandGroup.add(new AddCommand(newHouseNumberNode));
+                commandGroup.add(new AddCommand(MainApplication.getLayerManager().getEditDataSet(), newHouseNumberNode));
                 houseNumberNodes.add(newHouseNumberNode);   // Street, etc information to be added later
 
@@ -863 +869 @@
                 newHouseNumberNode.put("addr:housenumber", newHouseNumber);
 
-                commandGroup.add(new AddCommand(newHouseNumberNode));
+                commandGroup.add(new AddCommand(MainApplication.getLayerManager().getEditDataSet(), newHouseNumberNode));
                 houseNumberNodes.add(newHouseNumberNode);   // Street, etc information to be added later
 
@@ -1011 +1017 @@
 
         String streetName = selectedStreet.get("name");
+        DataSet currentDataSet = MainApplication.getLayerManager().getEditDataSet();
 
         if (addrInterpolationWay != null) {
@@ -1018 +1025 @@
 
             // De-select address interpolation way; leave street selected
-            DataSet currentDataSet = Main.getLayerManager().getEditDataSet();
-            if (currentDataSet != null) {
-                currentDataSet.clearSelection(addrInterpolationWay);
-                currentDataSet.clearSelection(lastNode);  // Workaround for JOSM Bug #3838
-            }
+            currentDataSet.clearSelection(addrInterpolationWay);
+            currentDataSet.clearSelection(lastNode);  // Workaround for JOSM Bug #3838
 
             String interpolationTagValue = selectedMethod;
@@ -1052 +1056 @@
             // Relation button was selected
             if (associatedStreetRelation == null) {
-                CreateRelation(streetName);
+                CreateRelation(currentDataSet, streetName);
                 // relationChanged = true;   (not changed since it was created)
             }
@@ -1070 +1074 @@
                 AddToRelation(associatedStreetRelation, node, "house");
             }
+            Map<String, String> tags = new HashMap<>();
             if ((city != null) || (streetNameButton.isSelected())) {
                 // Include street unconditionally if adding nodes only or city name specified
-                commandGroup.add(new ChangePropertyCommand(node, "addr:street", streetName));
+                tags.put("addr:street", streetName);
             }
             // Set or remove remaining optional fields
-            commandGroup.add(new ChangePropertyCommand(node, "addr:city", city));
-            commandGroup.add(new ChangePropertyCommand(node, "addr:state", state));
-            commandGroup.add(new ChangePropertyCommand(node, "addr:postcode", postCode));
-            commandGroup.add(new ChangePropertyCommand(node, "addr:country", country));
-            commandGroup.add(new ChangePropertyCommand(node, "addr:full", fullAddress));
+            tags.put("addr:city", city);
+            tags.put("addr:state", state);
+            tags.put("addr:postcode", postCode);
+            tags.put("addr:country", country);
+            tags.put("addr:full", fullAddress);
+            commandGroup.add(new ChangePropertyCommand(currentDataSet, Collections.singleton(node), tags));
         }
 
@@ -1087 +1093 @@
 
         Main.main.undoRedo.add(new SequenceCommand(tr("Address Interpolation"), commandGroup));
-        Main.map.repaint();
+        MainApplication.getLayerManager().getEditLayer().invalidate();
 
         return true;
@@ -1109 +1115 @@
 
     // Create Associated Street relation, add street, and add to list of commands to perform
-    private void CreateRelation(String streetName) {
+    private void CreateRelation(DataSet currentDataSet, String streetName) {
         associatedStreetRelation = new Relation();
         associatedStreetRelation.put("name", streetName);
@@ -1115 +1121 @@
         RelationMember newStreetMember = new RelationMember("street", selectedStreet);
         associatedStreetRelation.addMember(newStreetMember);
-        commandGroup.add(new AddCommand(associatedStreetRelation));
+        commandGroup.add(new AddCommand(currentDataSet, associatedStreetRelation));
     }
 

applications/editors/josm/plugins/addrinterpolation/src/org/openstreetmap/josm/plugins/AddrInterpolation/AddrInterpolationPlugin.java

@@ -2 +2 @@
 package org.openstreetmap.josm.plugins.AddrInterpolation;
 
-import org.openstreetmap.josm.Main;
+import org.openstreetmap.josm.gui.MainApplication;
 import org.openstreetmap.josm.gui.MainMenu;
 import org.openstreetmap.josm.plugins.Plugin;
@@ -9 +9 @@
 public class AddrInterpolationPlugin extends Plugin {
 
-    AddrInterpolationAction action = null;
-
     /**
      * constructor
@@ -16 +14 @@
     public AddrInterpolationPlugin(PluginInformation info) {
         super(info);
-        action = new AddrInterpolationAction();
-        MainMenu.add(Main.main.menu.dataMenu, action, false, 0);
+        MainMenu.add(MainApplication.getMenu().dataMenu, new AddrInterpolationAction(), false, 0);
     }
 }

applications/editors/josm/plugins/addrinterpolation/src/org/openstreetmap/josm/plugins/AddrInterpolation/EscapeDialog.java

@@ -53 +53 @@
     protected JRootPane createRootPane() {
         ActionListener escapeActionListener = new ActionListener() {
+            @Override
             public void actionPerformed(ActionEvent actionEvent) {
                 dispose();
-                // setVisible(false);
             }
         };