Changeset 3344 in josm for trunk/src/org

Timestamp:

2010-06-26T21:09:24+02:00 (14 years ago)

Author:

bastiK

Message:

fixed #4259 - Authentication dialog appears several times while uploading a changeset

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/Preferences.java (modified) (1 diff)
• gui/io/UploadStrategy.java (modified) (2 diffs)
• io/OsmConnection.java (modified) (1 diff)
• io/auth/CredentialsManagerFactory.java (modified) (1 diff)
• io/auth/JosmPreferencesCredentialManager.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/data/Preferences.java

@@ -719 +719 @@
     }
     synchronized public void removeFromCollection(String key, String value) {
-        List<String> a = new ArrayList<String>(getCollection(key, null));
+        List<String> a = new ArrayList<String>(getCollection(key, Collections.<String>emptyList()));
         a.remove(value);
         putCollection(key, a);

trunk/src/org/openstreetmap/josm/gui/io/UploadStrategy.java

@@ -64 +64 @@
      */
     public static UploadStrategy getFromPreferences() {
-        String v = Main.pref.get("osm-server.upload-strategy");
+        String v = Main.pref.get("osm-server.upload-strategy", null);
         if (v == null) {
             // legacy support. Until 12/2009 we had osm-server.atomic-upload only.
@@ -70 +70 @@
             // When the preferences are saved the next time, "osm-server.upload-strategy"
             // will be inserted.
-            v = Main.pref.get("osm-server.atomic-upload");
+            v = Main.pref.get("osm-server.atomic-upload", null);
             if (v != null) {
                 Main.pref.removeFromCollection("osm-server.atomic-upload", v);
+            } else {
+                v = "";
             }
             v = v.trim().toLowerCase();

trunk/src/org/openstreetmap/josm/io/OsmConnection.java

@@ -73 +73 @@
      *
      * @param con the connection
-     * @throws OsmTransferException thrown is something went wrong. Check for nested exceptions
+     * @throws OsmTransferException thrown if something went wrong. Check for nested exceptions
      */
     protected void addBasicAuthorizationHeader(HttpURLConnection con) throws OsmTransferException {

trunk/src/org/openstreetmap/josm/io/auth/CredentialsManagerFactory.java

@@ -17 +17 @@
      */
     static public CredentialsManager getCredentialManager() {
-        if (instance == null)
-            return new JosmPreferencesCredentialManager();
+        if (instance == null) {
+            instance =  new JosmPreferencesCredentialManager();
+        }
         return instance;
     }

trunk/src/org/openstreetmap/josm/io/auth/JosmPreferencesCredentialManager.java

@@ -4 +4 @@
 import java.net.PasswordAuthentication;
 import java.net.Authenticator.RequestorType;
+import java.util.HashMap;
+import java.util.Map;
 
 import org.openstreetmap.josm.Main;
@@ -17 +19 @@
 public class JosmPreferencesCredentialManager implements CredentialsManager {
 
+    Map<RequestorType, PasswordAuthentication> memoryCredentialsCache = new HashMap<RequestorType, PasswordAuthentication>();
     /**
      * @see CredentialsManager#lookup(RequestorType)
@@ -80 +83 @@
         CredentialsManagerResponse response = new CredentialsManagerResponse();
 
-        if (noSuccessWithLastResponse|| username.equals("") || password.equals("")) {
+        /*
+         * Last request was successful and there was no credentials stored
+         * in file. -> Try to recall credentials that have been entered
+         * manually in this session.
+         */
+        if (!noSuccessWithLastResponse && credentials == null && memoryCredentialsCache.containsKey(requestorType)) {
+            PasswordAuthentication pa = memoryCredentialsCache.get(requestorType);
+            response.setUsername(pa.getUserName());
+            response.setPassword(pa.getPassword());
+            response.setCanceled(false);
+        /*
+         * Prompt the user for credentials. This happens the first time each
+         * josm start if the user does not save the credentials to preference
+         * file (username=="") and each time after authentication failed
+         * (noSuccessWithLastResponse == true).
+         */
+        } else if (noSuccessWithLastResponse || username.equals("") || password.equals("")) {
             CredentialDialog dialog = null;
             switch(requestorType) {
@@ -97 +116 @@
                         response.getPassword()
                 ));
+            /*
+             * User decides not to save credentials to file. Keep it
+             * in memory so we don't have to ask over and over again.
+             */
+            } else {
+                PasswordAuthentication pa = new PasswordAuthentication(dialog.getUsername(), dialog.getPassword());
+                memoryCredentialsCache.put(requestorType, pa);
             }
+        /*
+         * We got it from file.
+         */
         } else {
             response.setUsername(username);