Changeset 33232 in osm for applications/editors/josm/plugins/mapdust

Timestamp:

2017-04-13T23:09:10+02:00 (7 years ago)

Author:

donvip

Message:

fix error-prone warnings

Location:

applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust

Files:

• gui/value/MapdustPluginState.java (modified) (1 diff)
• gui/value/MapdustServiceCommand.java (modified) (2 diffs)
• service/value/MapdustResponseStatusCode.java (modified) (1 diff)
• util/http/HttpConnector.java (modified) (3 diffs)
• util/retry/RetryMode.java (modified) (1 diff)

applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/value/MapdustPluginState.java

@@ -44 +44 @@
 
     /** The value of the state */
-    private String value;
+    private final String value;
 
     /**

applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/value/MapdustServiceCommand.java

@@ -45 +45 @@
 
     /** The key */
-    private String key;
+    private final String key;
 
     /** The value */
-    private String value;
-
-    /**
-     * Builds a new <code>MapdustServiceCommand</code> object
-     */
-    MapdustServiceCommand() {}
+    private final String value;
 
     /**
@@ -79 +74 @@
         return value;
     }
-
 }

applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/value/MapdustResponseStatusCode.java

@@ -73 +73 @@
 
     /** The code of the error */
-    private Integer statusCode;
+    private final Integer statusCode;
 
     /** The Mapdust API code */
-    private Integer apiCode;
+    private final Integer apiCode;
 
     /** The description of the response code */
-    private String description;
+    private final String description;
 
     /**

applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/http/HttpConnector.java

@@ -38 +38 @@
 import java.net.URL;
 import java.net.URLEncoder;
+import java.nio.charset.StandardCharsets;
 import java.util.Map;
 
@@ -164 +165 @@
                 if (sbEncodeParameters.length() > 0) {
                     try (OutputStreamWriter out =
-                            new OutputStreamWriter(connection.getOutputStream())) {
+                            new OutputStreamWriter(connection.getOutputStream(), StandardCharsets.UTF_8)) {
                         out.write(sbEncodeParameters.toString());
                     }
@@ -207 +208 @@
     protected String readContent(Object obj) throws IOException {
         String result = "";
-        InputStreamReader in = new InputStreamReader((InputStream) obj);
+        InputStreamReader in = new InputStreamReader((InputStream) obj, StandardCharsets.UTF_8);
         BufferedReader buff = new BufferedReader(in);
         String line = "";

applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/retry/RetryMode.java

@@ -48 +48 @@
 
     /** The name of the retry mode*/
-    private String name;
+    private final String name;
 
     /**