Changeset 33031 in osm

Timestamp:

2016-10-11T11:23:59+02:00 (8 years ago)

Author:

bastik

Message:

fixed #josm11878 Terracer plugin: error when creating associatedStreet relation

File:

• applications/editors/josm/plugins/terracer/src/terracer/TerracerAction.java (modified) (5 diffs)

applications/editors/josm/plugins/terracer/src/terracer/TerracerAction.java

@@ -371 +371 @@
             for (int i = 0; i < nb; ++i) {
                 final Way terr;
-                if (i > 0 || keepOutline) {
+                boolean createNewWay = i > 0 || keepOutline;
+                if (createNewWay) {
                     terr = new Way();
                     // add the tags of the outline to each building (e.g. source=*)
@@ -386 +387 @@
                 terr.addNode(newNodes[0][i]);
 
-                ways.add(addressBuilding(terr, street, streetName, associatedStreet, housenumbers, i,
-                        from != null ? Integer.toString(from + i * step) : null, buildingValue));
-
-                if (i > 0 || keepOutline) {
+                addressBuilding(terr, street, streetName, associatedStreet, housenumbers, i,
+                        from != null ? Integer.toString(from + i * step) : null, buildingValue);
+
+                if (createNewWay) {
+                    ways.add(terr);
                     this.commands.add(new AddCommand(terr));
                 } else {
+                    ways.add(outline);
                     this.commands.add(new ChangeCommand(outline, terr));
                 }
@@ -408 +411 @@
         } else {
             // Single building, just add the address details
-            ways.add(addressBuilding(outline, street, streetName, associatedStreet, housenumbers, 0, start, buildingValue));
+            addressBuilding(outline, street, streetName, associatedStreet, housenumbers, 0, start, buildingValue);
+            ways.add(outline);
         }
 
@@ -508 +512 @@
      * @throws UserCancelException
      */
-    private Way addressBuilding(Way outline, Way street, String streetName, Relation associatedStreet,
+    private void addressBuilding(Way outline, Way street, String streetName, Relation associatedStreet,
             List<Node> housenumbers, int i, String defaultNumber, String buildingValue) throws UserCancelException {
         Node houseNum = (housenumbers != null && i >= 0 && i < housenumbers.size()) ? housenumbers.get(i) : null;
@@ -541 +545 @@
             }
         }
-        return outline;
     }