Changeset 32921 in osm

Timestamp:

2016-09-03T22:23:26+02:00 (8 years ago)

Author:

donvip

Message:

fix #josm13501 - robustness against degraded case

Location:

applications/editors/josm/plugins/alignways/src/com/tilusnet/josm/plugins/alignways

Files:

• AlignWaysAlgnSegment.java (modified) (1 diff)
• AlignWaysSegment.java (modified) (3 diffs)

applications/editors/josm/plugins/alignways/src/com/tilusnet/josm/plugins/alignways/AlignWaysAlgnSegment.java

@@ -114 +114 @@
      */
     private EastNorth getPivotCoord(PivotLocations pp) {
-        switch (pp) {
-        case NONE:
-            return null;
-        case NODE1:
-            return segment.way.getNode(segment.lowerIndex).getEastNorth();
-        case NODE2:
-            return segment.way.getNode(segment.lowerIndex + 1).getEastNorth();
-        case CENTRE:
-            return getPivotCoord(PivotLocations.NODE1).getCenter(
-                    getPivotCoord(PivotLocations.NODE2));
-        default:
-            // Should never happen
+        try {
+            EastNorth n1;
+            EastNorth n2;
+            switch (pp) {
+            case NODE1:
+                return segment.way.getNode(segment.lowerIndex).getEastNorth();
+            case NODE2:
+                return segment.way.getNode(segment.lowerIndex + 1).getEastNorth();
+            case CENTRE:
+                n1 = getPivotCoord(PivotLocations.NODE1);
+                n2 = getPivotCoord(PivotLocations.NODE2);
+                return n1 != null && n2 != null ? n1.getCenter(n2) : null;
+            case NONE:
+            default:
+                return null;
+            }
+        } catch (IndexOutOfBoundsException e) {
+            Main.error(e);
             return null;
         }

applications/editors/josm/plugins/alignways/src/com/tilusnet/josm/plugins/alignways/AlignWaysSegment.java

@@ -14 +14 @@
 import java.util.HashSet;
 
+import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.data.Bounds;
 import org.openstreetmap.josm.data.osm.Node;
@@ -54 +55 @@
     void setSegmentEndpoints(WaySegment segment) {
         if (segment != null) {
-            Node node1 = segment.way.getNode(segment.lowerIndex);
-            Node node2 = segment.way.getNode(segment.lowerIndex + 1);
+            try {
+                Node node1 = segment.way.getNode(segment.lowerIndex);
+                Node node2 = segment.way.getNode(segment.lowerIndex + 1);
 
-            segmentEndPoints = new HashSet<>();
-            segmentEndPoints.add(node1);
-            segmentEndPoints.add(node2);
+                segmentEndPoints = new HashSet<>();
+                segmentEndPoints.add(node1);
+                segmentEndPoints.add(node2);
+            } catch (IndexOutOfBoundsException e) {
+                Main.error(e);
+            }
         }
     }
@@ -97 +102 @@
 
     protected void drawSegment(Graphics2D g, MapView mv) {
-        Node n1 = segment.way.getNode(segment.lowerIndex);
-        Node n2 = segment.way.getNode(segment.lowerIndex + 1);
+        try {
+            Node n1 = segment.way.getNode(segment.lowerIndex);
+            Node n2 = segment.way.getNode(segment.lowerIndex + 1);
 
-        Line2D newline = new Line2D.Double(mv.getPoint(n1), mv.getPoint(n2));
-        g.draw(newline);
+            g.draw(new Line2D.Double(mv.getPoint(n1), mv.getPoint(n2)));
+        } catch (IndexOutOfBoundsException e) {
+            Main.error(e);
+        }
     }