Changeset 32863 in osm for applications/editors

Timestamp:

2016-08-21T20:23:56+02:00 (8 years ago)

Author:

holgermappt

Message:

Move layer change listeners back to map mode constructor and destroy(). See #josm13209, #josm13261, #josm13262.

File:

• applications/editors/josm/plugins/photoadjust/src/org/openstreetmap/josm/plugins/photoadjust/PhotoAdjustMapMode.java (modified) (7 diffs)

applications/editors/josm/plugins/photoadjust/src/org/openstreetmap/josm/plugins/photoadjust/PhotoAdjustMapMode.java

@@ -43 +43 @@
     private IconToggleButton mmButton;
     private PhotoAdjustWorker worker;
+    /** True if one existing GeoImageLayer is to be ignored. */
+    private boolean ignoreOneGILayer = false;
 
     public PhotoAdjustMapMode(MapFrame mapFrame, PhotoAdjustWorker worker) {
@@ -55 +57 @@
         initAdapters();
         this.worker = worker;
+        Main.getLayerManager().addLayerChangeListener(this);
+        Main.getLayerManager().addActiveLayerChangeListener(this);
     }
 
@@ -133 +137 @@
         super.enterMode();
         modeSelected = true;
-        Main.getLayerManager().addLayerChangeListener(this);
-        Main.getLayerManager().addActiveLayerChangeListener(this);
         // Activate the mode only if the current layer is not a GeoImageLayer.
         // GeoImageLayer's are handled by the plug-in directly.
@@ -145 +147 @@
     public void exitMode() {
         super.exitMode();
-        Main.getLayerManager().removeActiveLayerChangeListener(this);
-        Main.getLayerManager().removeLayerChangeListener(this);
         deactivateMode();
         modeSelected = false;
@@ -168 +168 @@
 
     @Override
-    public void layerRemoving(LayerRemoveEvent e) {
+    public void layerRemoving(LayerRemoveEvent lre) {
+        if (lre.getRemovedLayer() instanceof GeoImageLayer) {
+            // A GeoImageLayer is about to be removed.  We ignore this layer
+            // in the following update methods to get the correct number of
+            // future GeoImageLayers.
+            ignoreOneGILayer = true;
+        }
         if (modeActive) updateStatusLine();
         updateButtonState();
+        ignoreOneGILayer = false;
     }
 
@@ -213 +220 @@
     private boolean hasLayersToAdjust() {
         if (Main.map == null || Main.map.mapView == null) return false;
-        return ! Main.getLayerManager().getLayersOfType(GeoImageLayer.class).isEmpty();
+        int giLayerNum = Main.getLayerManager().getLayersOfType(GeoImageLayer.class).size();
+        if (ignoreOneGILayer) {
+            giLayerNum--;
+        }
+        return giLayerNum > 0;
     }
 
@@ -229 +240 @@
         return all;
     }
+
+ 
+    @Override 
+    public void destroy() { 
+        super.destroy(); 
+        Main.getLayerManager().removeActiveLayerChangeListener(this);
+        Main.getLayerManager().removeLayerChangeListener(this);
+    } 
+
 }